Azure-Sentinel
Azure-Sentinel copied to clipboard
Rebrand Thycotic to Delinea
Required items, please complete
Change(s):
- See guidance below
Reason for Change(s):
- See guidance below
Version Updated:
- Required only for Detections/Analytic Rule templates
- See guidance below
Testing Completed:
- See guidance below
Checked that the validations are passing and have addressed any issues that are present:
- See guidance below
Guidance <- remove section before submitting
Before submitting this PR please ensure that you have read the following sections and filled out the changes, reason for change and testing complete sections:
Thank you for your contribution to the Microsoft Sentinel Github repo.
Details of the code changes in your submitted PR. Providing descriptions for pull requests ensures there is context to changes being made and greatly enhances the code review process. Providing associated Issues that this resolves also easily connects the reason.
Change(s):
- Updated syntax for XYZ.yaml
Reason for Change(s):
- New schema used for XYZ.yaml
- Resolves ISSUE #1234
Version updated:
- Yes
- Detections/Analytic Rule templates are required to have the version updated
The code should have been tested in a Microsoft Sentinel environment that does not have any custom parsers, functions or tables, so that you validate no incorrect syntax and execution functions properly. If your submission requires a custom parser or function, it must be submitted with the PR.
Testing Completed:
- Yes/No/Need Help
Note: If updating a detection, you must update the version field.
Before the submission has been made, please look at running the KQL and Yaml Validation Checks locally. https://github.com/Azure/Azure-Sentinel#run-kql-validation-locally
Checked that the validations are passing and have addressed any issues that are present:
- Yes/No/Need Help
Note: Let us know if you have tried fixing the validation error and need help.
References:
@v-sabiraj I have signed the CLA in a different PR for Microsoft Power automate on behalf of Delinea. @gaurava-delinea works on my team. How can we proceed with that license check? Can it be assigned to me?
Hey @gaurava-delinea, can you please sign it once again from here? as check is blocked because of that, thanks.
@v-sabiraj when can we expect this PR to be accepted and merged?
@gaurava-delinea, there is error in workbook, please check and update, thanks.
Hey @gaurava-delinea, please update Sample data files, ThycoticSourceData.csv and ThycoticSourceData.json, thanks.
@v-sabiraj the changes were submitted by @gaurava-delinea in the most recent commit. Please evaluate.
@gaurava-delinea, there is error in workbook, please check and update, thanks.
@gaurava-delinea / @tylerezimmerman, still the workbook is not visible after deployment, can you check on this
@gaurava-delinea, there is error in workbook, please check and update, thanks.
@gaurava-delinea / @tylerezimmerman, still the workbook is not visible after deployment, can you check on this
@gaurava-delinea, the possible reason for this should be the schema, please check and update "version": "Notebook/1.1", thanks.
@v-sabiraj the change was updated by @gaurava-delinea
@gaurava-delinea, the workbook and data connector queries are using Delinea software but in sample data it is still thycotic software, please update sample data file accordingly, thanks.
@gaurava-delinea, can you please add updated workbook preview images, thanks.
@gaurava-delinea, the workbook and data connector queries are using Delinea software but in sample data it is still thycotic software, please update sample data file accordingly, thanks.
@v-sabiraj @tylerezimmerman Done the additional commit. Also find some more places where Thycotic references being used in many places. Kindly review it.
@v-sabiraj please review the most recent commit. We are unable to generate any rebranded images until this PR is approved and we can view it on the preview instance. Then we can submit another PR with the updated changes.
@gaurava-delinea, @tylerezimmerman, workbook validations are failing as the workbook contains info of a resource. A workbook template must not contain any references to resources. Please check and update, thanks.
@gaurava-delinea, @tylerezimmerman, workbook validations are failing as the workbook contains info of a resource. A workbook template must not contain any references to resources. Please check and update, thanks.
@v-sabiraj This comment is not clear to me. could you please highlight the line that is not needed.
Hi @gaurava-delinea, the value for fallbackResourceIds in workbook refers to some resources, initially it was just "", so can you check on that?
Hi @gaurava-delinea, the value for fallbackResourceIds in workbook refers to some resources, initially it was just "", so can you check on that?
@v-sabiraj @tylerezimmerman Pushed the latest workbook file. comment Resolved. Please approve the PR
@v-sabiraj any update here?
Hey @tylerezimmerman/@gaurava-delinea, the checks are failing, not sure why the validations are failing for the files that are not added in the PR, I'll check on this, thanks.
@gaurava-delinea : Please replace "Azure Sentinel" to Microsoft Sentinel" where ever it's applicable.
@gaurava-delinea : Please replace "Azure Sentinel" to Microsoft Sentinel" where ever it's applicable.
@v-sabiraj @tylerezimmerman resolved the comment
@v-sabiraj please review the recently uploaded changes.