Azure-Sentinel
Azure-Sentinel copied to clipboard
Adding Azure DevOps data connector and onboarding scripts
Required items, please complete
Change(s):
- Adding data connector for Azure DevOps
Reason for Change(s):
- Didn't exist yet
Version Updated:
- Required only for Detections/Analytic Rule templates
- See guidance below
Testing Completed:
- Tested and validated see screenshots reamd.md for proof
Checked that the validations are passing and have addressed any issues that are present:
- See guidance below
removed external links from templates and documentation
@vmanojreddy I've also created a PR for the issue causing this pipeline not to run succesfully: https://github.com/Azure/Azure-Sentinel/pull/4738
@azurekid :Please resolve the validation checks (DataConnectorValidations)
@azurekid Logo need to svg format not be in png format. thanks!!
@azurekid In Create UI Definition logo not displaying properly. Please correct logo format and update in Create UI Definition. thanks!!!
@azurekid Please provide correct folder structure. Please refer below path for the folder structure. Refer pat:https://github.com/Azure/Azure-Sentinel/tree/master/Solutions/Alsid%20For%20AD
@azurekid Please provide correct folder structure. Please refer below path for the folder structure. Refer pat:https://github.com/Azure/Azure-Sentinel/tree/master/Solutions/Alsid%20For%20AD
@vmanojreddy Thanks for the feedback, Do I also need to follow the solutions structure for just a data connector? If so, I will update the folder structure with pleasure of course
@azurekid Please provide correct folder structure. Please refer below path for the folder structure. Refer pat:https://github.com/Azure/Azure-Sentinel/tree/master/Solutions/Alsid%20For%20AD
@vmanojreddy Thanks for the feedback, Do I also need to follow the solutions structure for just a data connector? If so, I will update the folder structure with pleasure of course
@azurekid Please follow folder structure for the package as well and provide zip with latest version. thanks!!!
@azurekid Please provide correct folder structure. Please refer below path for the folder structure. Refer pat:https://github.com/Azure/Azure-Sentinel/tree/master/Solutions/Alsid%20For%20AD
@vmanojreddy Thanks for the feedback, Do I also need to follow the solutions structure for just a data connector? If so, I will update the folder structure with pleasure of course
@azurekid Please follow folder structure for the package as well and provide zip with latest version. thanks!!!
- [x] added the data connector as a solution.
- [x] updated logo to .svg
- [x] updated raw links to Azure/Azure-Sentinel/master
- [x] removed raw links to SecureHats/Azure-Sentinel/main
@vmanojreddy @v-spadarthi,
Anything else I need to do?
@azurekid Please move readme file into data connector folder.
@azurekid Logo Should be under 5 Kb. Thanks!!!
@azurekid In Data connector folder why we are adding another uiMainTemplate.json file.
@azurekid In Data connector folder why we are adding another uiMainTemplate.json file.
uiMainTemplate.json is used for the mainTemplate.json deployment the other uiDefinition file is related to the azuredeploy.json
This has to do with the different deployment methods that can be used
@azurekid Logo Should be under 5 Kb. Thanks!!!
I cannot make the file any smaller than it is now. Shall I just completely remove the logo and references?
@azurekid why we are maintaining same files at data connector and in solution folder . Please maintain all files in the solution folder remove from data connector folder. Reference Path : https://github.com/Azure/Azure-Sentinel/tree/master/Solutions/Bitglass
@azurekid In check DataConnectorValidations is failing due schema is matching sample template. can you please check once.
@azurekid In check DataConnectorValidations is failing due schema is matching sample template. can you please check once.
I am aware of this, that isxwhycI also created a PR to fix the validation script. It seems to miss the standard table and schema for AzureDevOpsAuditing.
See PR #4738
@azurekid In check DataConnectorValidations is failing due schema is matching sample template. can you please check once.
I am aware of this, that is why I also created a PR to fix the validation script. It seems to miss the standard table and schema for AzureDevOpsAuditing.
See PR #4738
@azurekid why we are maintaining same files at data connector and in solution folder . Please maintain all files in the solution folder remove from data connector folder. Reference Path : https://github.com/Azure/Azure-Sentinel/tree/master/Solutions/Bitglass
Hi @vmanojreddy vmanojreddy, Maybe it is more useful to have a call about this. I initially created just a data connector and opened a PR Then I got a question from you to create a solution for it. I asked if this was the new standard but never got a reply on it Now I'm getting the question of why it is a data connector.
So question: If we are creating just a data connector, does this need to be a solution? There are several examples of recent data connectors being added without a solution pack.
Waiting for your reply.
Hi @azurekid, Please accept our apologies for not communicating the things clearly to you. I am was in migration mode and migrating all the old solutions to new template specs and missed out this. really sorry for this.
For maintaining constancy all file should be in solution folder and following one folder structure in solution folder Folder structure reference Path. So, could you please remove file from data connector folder and maintain files in solution folder only. thanks!!!
@azurekid Can you please do the needful. Thanks
@azurekid please address above comment and we have merged the 4738 but still checks are not passing. Please take a look once. thanks!!!
hi @azurekid Can you please address @v-marimanda comments, Thanks
Hi @azurekid Can you please remove the content inside the individual data connector folder. If you want to push any changes, please add those inside solution folders.
Hi @azurekid Can you please remove the content inside the individual data connector folder. If you want to push any changes, please add those inside solution folders.
done
Hi @azurekid Sorry for multiple comments, I just noticed that you have created Package with 1.0.0 version. We have recently changed the solutioning approach. Can you please use V2 version of tool to create package, new version can be found here . All packages that are created using V2 version of the tool starts with v2.0.0 so, please use the version for your package 2.0.0
Hi @azurekid Sorry for multiple comments, I just noticed that you have created Package with 1.0.0 version. We have recently changed the solutioning approach. Can you please use V2 version of tool to create package, new version can be found here . All packages that are created using V2 version of the tool starts with v2.0.0 so, please use the version for your package 2.0.0
Hi @azurekid Please accommodate above changes. Let us know if you need any help over there. Thanks
Hi @azurekid Please accommodate above changes. Let us know if you need any help over there. Thanks
Hi @azurekid Please accommodate above changes. Let us know if you need any help over there. Thanks