Azure-Sentinel icon indicating copy to clipboard operation
Azure-Sentinel copied to clipboard

Gem for updated Logstash plugin needs to be updated at rubygems.org

Open TheCloudScout opened this issue 11 months ago • 7 comments

Describe the bug Me and @pkhabazi created a PR recently because we developed a new feature for the Logstash output plugin for Log Analytics. This PR recently got approved and merged but now we need to make sure the respective Gem 💎 gets updated at rubygems.org as well. This ensures automatic updates for existing users and easier installation for new users.

But since Microsoft is the owner of this Gem, we need your help getting this done.

To Reproduce

Expected behavior Please upload the new Gem 💎 for us to rubygems.org 😊

Additional context I spoke with Haim Rubinstein about this. Apparantly a member of him team is able to perform these steps and he asked me to create this issue here.

If you have any question don't hesitate to reach out!

TheCloudScout avatar Mar 07 '24 16:03 TheCloudScout

Hi @TheCloudScout ,Could you please share email id of team member will connect over teams meeting for getting this done

v-muuppugund avatar Mar 08 '24 02:03 v-muuppugund

Hi @TheCloudScout ,Could you please share email id of team member will connect over teams meeting for getting this done

Please invite [email protected] and [email protected]

TheCloudScout avatar Mar 08 '24 07:03 TheCloudScout

Hi @TheCloudScout ,Could you please share email id of team member will connect over teams meeting for getting this done

Please invite [email protected] and [email protected]

Noted,Will ask for convenient time slots for teams meeting for this issue.

v-muuppugund avatar Mar 08 '24 10:03 v-muuppugund

Hi @TheCloudScout ,Could you please share email id of team member will connect over teams meeting for getting this done

Please invite [email protected] and [email protected]

Noted,Will ask for convenient time slots for teams meeting for this issue.

We are both currently in Redmond for the MVP summit. So in PST time zone. Please let us now when you have time.

pkhabazi avatar Mar 08 '24 23:03 pkhabazi

Hi @TheCloudScout ,Could you please share email id of team member will connect over teams meeting for getting this done

Please invite [email protected] and [email protected]

Noted,Will ask for convenient time slots for teams meeting for this issue.

We are both currently in Redmond for the MVP summit. So in PST time zone. Please let us now when you have time.

Could you please share time slots for teams meeting and asked the same over email

v-muuppugund avatar Mar 09 '24 03:03 v-muuppugund

Hi @TheCloudScout ,Could you please share email id of team member will connect over teams meeting for getting this done

Please invite [email protected] and [email protected]

Noted,Will ask for convenient time slots for teams meeting for this issue.

We are both currently in Redmond for the MVP summit. So in PST time zone. Please let us now when you have time.

Could you please share time slots for teams meeting and asked the same over email

As discussed over email,will schedule meeting on 18Mar2024

v-muuppugund avatar Mar 15 '24 04:03 v-muuppugund

Hi @pkhabazi / @TheCloudScout ,as discussed yesterday over call,waiting for credentials,once received ,will update you,so we can have a call

v-muuppugund avatar Mar 19 '24 04:03 v-muuppugund

Hi @pkhabazi / @TheCloudScout got response from Haim that the commit will be reverted in PR,so there will be no action at rubygems.org ,so closing the issue,If you still need support for this issue(https://github.com/Azure/Azure-Sentinel/issues/10109), feel free to re-open at any time. Thank you for your co-operation!

v-muuppugund avatar Apr 02 '24 09:04 v-muuppugund

Hi @v-muuppugund,

the commit will be reverted in PR

Are you saying that you're going to revert/undo the entire PR? What is the reason behind this? Does Haim not agree with the changes made by us?

Please me and @pkhabazi know what didn't work for him and need to be changed. We want to work together to get things right.

Thank you!

TheCloudScout avatar Apr 02 '24 10:04 TheCloudScout

Hi @v-muuppugund,

the commit will be reverted in PR

Are you saying that you're going to revert/undo the entire PR? What is the reason behind this? Does Haim not agree with the changes made by us?

Please me and @pkhabazi know what didn't work for him and need to be changed. We want to work together to get things right.

Thank you!

Hi @TheCloudScout ,Ok,Sure,shared details over individual teams chat of email,please let me know there,so will proceed further steps.

v-muuppugund avatar Apr 02 '24 11:04 v-muuppugund

Where can we get updated about the status of this work? We would need a ballpark estimate of when we would get generally available managed identity support on this logstash output plugin. Thanks.

LuKePicci avatar Apr 12 '24 10:04 LuKePicci

@LuKePicci, after having multiple sessions with the MS PM team, they have decided that this feature will not be implemented in the current version that is published on RubyGems. This is mainly because they are in the process of planning a GA for the module in the current version without support for MI, and I can't share more details due to NDA constraints. The current code base will also be reverted to the earlier version without support for MI, as mentioned above.

Therefore, we have decided and agreed with the MS team to bring the current code base with support for MI to a separate GitHub repository and release it under a new Gem name. We are still in the process of updating the documentation, etc. However, the links are already online; feel free to test and share your feedback with us.

Link to the GitHub Repo: https://github.com/pkhabazi/microsoft-sentinel-logstash-output link to the new RubyGem: https://rubygems.org/gems/microsoft-sentinel-logstash-output

pkhabazi avatar Apr 12 '24 10:04 pkhabazi

Awesome, thanks for the update.

LuKePicci avatar Apr 12 '24 10:04 LuKePicci

Trying to test the new plugin, it installs correctly but logstash says: Unable to configure plugins: (PluginLoadingError) Couldn't find any output plugin named 'microsoft-sentinel-logstash-output'. Are you sure this is correct? Trying to load the microsoft-sentinel-logstash-output output plugin resulted in this error: Unable to load the requested plugin named microsoft-sentinel-logstash-output of type output. The plugin is not installed.

This is logstash configuration file:

output {
     microsoft-sentinel-logstash-output {
                      managed_identity => true
                      data_collection_endpoint => "${DATACOLLECTION_ENDPOINT}"
                      dcr_immutable_id => "${DCR_IMMUTABLE_ID}"
                      dcr_stream_name => "${DCR_STREAM_NAME}" 
    }
}

Here the plugin installation output:

Using bundled JDK: /usr/share/logstash/jdk
Validating microsoft-sentinel-logstash-output
Resolving mixin dependencies
Installing microsoft-sentinel-logstash-output
Installation successful

I'm using logstash 8.8.1

nangirl avatar Apr 16 '24 19:04 nangirl

Hi @nangirl

I guess you were a bit too early. We hadn't finished sending the latest version to rubygems. Since the plug-in name had to change, we left a couple of instances in the code which we had to rename as well.

If you now run

sudo /usr/share/logstash/bin/logstash-plugin install microsoft-sentinel-logstash-output

You'll end up with version 1.2.3. And this is confirmed to work properly as detailed on Microsoft Github page.

This was the config I used:

output {
        microsoft-sentinel-logstash-output {
                managed_identity => true
                data_collection_endpoint => "https://<dceuri>.westeurope-1.ingest.monitor.azure.com"
                dcr_immutable_id => "dcr-<immutableid>"
                dcr_stream_name => "Custom-c<tablename>"
        }
}

It's a pity we had to renamed to be able to publish it this way. But I think my customers will appreciate the easier installation/update mechanism instead.

Please let me know if it worked out for you as well!

TheCloudScout avatar Apr 17 '24 15:04 TheCloudScout

@LuKePicci and @nangirl feels ree to test the latest version as mentioned bij Koos and share your feedback/issues with us in the new project: https://github.com/pkhabazi/microsoft-sentinel-logstash-output

Koos and myself will be monitoring this project for questions/issues.

pkhabazi avatar Apr 18 '24 08:04 pkhabazi