AzOps icon indicating copy to clipboard operation
AzOps copied to clipboard

Added additional constructor for AzOpsRoleEligibilityScheduleRequest

Open borondy opened this issue 1 year ago • 0 comments

Overview/Summary

Added additional constructor for AzOpsRoleEligibilityScheduleRequest to be able to create RoleEligibilityScheduleRequest template based on the RoleEligibilitySchedule resource without an existing RoleEligibilityScheduleRequest resource. See reasons in #901.

NOTE Having the AdminAssign value burnt in, makes sense in our use case. Not sure if it is generally acceptable however? We skip the deployment of the AzOps Pull generated PRs, so false deployment can't automatically happen. These files are however required for us to be able to update the RoleEligibilityScheduleRequests.

This PR fixes/adds/changes/removes

  1. #901

Breaking Changes

  1. N/A

Testing Evidence

We were able to successfully create RoleEligibilityScheduleRequest templates during our pipeline runs where the actual Request was not found in azure: image

As part of this Pull Request I have

  • [x] Checked for duplicate Pull Requests
  • [x] Associated it with relevant issues, for tracking and closure.
  • [x] Ensured my code/branch is up-to-date with the latest changes in the main branch
  • [x] Performed testing and provided evidence.
  • [x] Updated relevant and associated documentation.

borondy avatar Oct 16 '24 14:10 borondy