fix: fix installContainerRuntime if condition bug and others

[Devinwong]

What type of PR is this?

/kind bug

What this PR does / why we need it:

• fix installContainerRuntime if condition
• fix missing stop-watched for benchmarking
• add readme to components.json modification
• add unit test for installContainerRuntime

Which issue(s) this PR fixes:

Fixes #

Requirements:

• [ ] uses conventional commit messages
• [x] includes documentation
• [x] adds unit tests
• [ ] tested upgrade from previous version

Special notes for your reviewer:

Release note:

none

[coveralls]

Pull Request Test Coverage Report for Build 9557805366

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 76.006%

---

Totals
Change from base Build 9554640287:	0.0%
Covered Lines:	2626
Relevant Lines:	3455

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 9557808860

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 76.006%

---

Totals
Change from base Build 9554640287:	0.0%
Covered Lines:	2626
Relevant Lines:	3455

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 9559203467

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 76.006%

---

Totals
Change from base Build 9554640287:	0.0%
Covered Lines:	2626
Relevant Lines:	3455

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 9566709378

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 76.006%

---

Totals
Change from base Build 9559713595:	0.0%
Covered Lines:	2626
Relevant Lines:	3455

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 9570593334

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 76.006%

---

Totals
Change from base Build 9559713595:	0.0%
Covered Lines:	2626
Relevant Lines:	3455

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 9572536333

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 76.006%

---

Totals
Change from base Build 9559713595:	0.0%
Covered Lines:	2626
Relevant Lines:	3455

---

💛 - Coveralls

[cameronmeissner]

will need a rebase from master

[coveralls]

Pull Request Test Coverage Report for Build 9672395949

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 5 of 6 (83.33%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-5.5%) to 70.516%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/agent/vhd/cache/cache.go	5	6	83.33%
<!--	Total:	5	6

Totals
Change from base Build 9668502527:	-5.5%
Covered Lines:	2626
Relevant Lines:	3724

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 9684457713

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 5 of 6 (83.33%) changed or added relevant lines in 1 file are covered.
• 88 unchanged lines in 2 files lost coverage.
• Overall coverage decreased (-5.5%) to 70.516%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/agent/vhd/cache/cache.go	5	6	83.33%
<!--	Total:	5	6

Files with Coverage Reduction	New Missed Lines	%
pkg/agent/bakerapi.go	10	91.53%
pkg/agent/baker.go	78	71.64%
<!--	Total:	88

Totals
Change from base Build 9668502527:	-5.5%
Covered Lines:	2626
Relevant Lines:	3724

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 9701687803

Details

• 5 of 6 (83.33%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.03%) to 70.516%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/agent/vhd/cache/cache.go	5	6	83.33%
<!--	Total:	5	6

Totals
Change from base Build 9693263400:	0.03%
Covered Lines:	2626
Relevant Lines:	3724

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 9719557086

Details

• 5 of 6 (83.33%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.03%) to 70.516%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/agent/vhd/cache/cache.go	5	6	83.33%
<!--	Total:	5	6

Totals
Change from base Build 9718319384:	0.03%
Covered Lines:	2626
Relevant Lines:	3724

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 9748013673

Details

• 5 of 6 (83.33%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.03%) to 70.516%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/agent/vhd/cache/cache.go	5	6	83.33%
<!--	Total:	5	6

Totals
Change from base Build 9747074137:	0.03%
Covered Lines:	2626
Relevant Lines:	3724

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 9749533682

Details

• 5 of 6 (83.33%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.03%) to 70.516%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/agent/vhd/cache/cache.go	5	6	83.33%
<!--	Total:	5	6

Totals
Change from base Build 9748032807:	0.03%
Covered Lines:	2626
Relevant Lines:	3724

---

💛 - Coveralls

[Devinwong]

seems like from the latest abe2e run mariner is trying to install the containerd version for ubuntu, which doesn't exist:

++ echo 1.7.15
+ VERSION_B=1.7.15
+ [[ 1.6.26 == \1\.\7\.\1\5 ]]
++ echo 1.6.26 1.7.15
++ sort -V
++ tr ' ' '\n'
+ sorted='1.6.26
1.7.15'
++ IFS=
++ echo '1.6.26
1.7.15'
++ cut '-d
' -f2
+ highestVersion=1.7.15
+ [[ 1.6.26 == 1.7.15 ]]
+ return 1
+ echo 'installing containerd version 1.7.15'
installing containerd version 1.7.15

...

++ seq 1 30
+ for i in $(seq 1 $retries)
+ dnf install -y moby-containerd-1.7.15
environment: line 4: ctr: command not found
Executed "bash -c cleanupImagesRun" 2 times
Fri Jul 12 00:15:24 UTC 2024,abtest7lln000000, endCleanUpKubeProxyImages
Last metadata expiration check: 7:13:34 ago on Thu Jul 11 17:01:47 2024.
No match for argument: moby-containerd-1.7.15
Error: Unable to find a match: moby-containerd-1.7.15

~~@cameronmeissner can you link me to this error?~~ I found the logs from the PR gate e2e. But the latest abe2e (manually triggered) doesn't have this error. https://msazure.visualstudio.com/CloudNativeCompute/_build/results?buildId=97984006&view=logs&j=beeeaba8-323e-5ce9-426a-8cbca9ffe3b0&t=b32dc13d-e9ba-5292-9703-579f43e16486