AgentBaker icon indicating copy to clipboard operation
AgentBaker copied to clipboard

perf: enable shallow replication

Open zachary-bailey opened this issue 1 year ago • 1 comments

What type of PR is this?

/kind performance

What this PR does / why we need it:

This PR changes the replication method for VHDs from full replication with the packer tool to shallow replication with a direct SIG API call. Currently, we are using the packer tool to fully replicate all non-arm64 VHDs to the SIG. For arm64 builds, a snapshot is created at the beginning of the build, updated at the end of the build, and then converted to the SIG.

This PR uses the arm64 publishing logic that is already in place to publish all VHDs to the SIG using shallow replication, with the exception of the confidential VM because it cannot be made into a snapshot.

In order to accomplish this, all references to arm64_os_disk* were changed to encompass all VHDs, all existing packer templates were modified to remove the shared_image_gallery_destination block, a new packer template was created to publish the confidential VM using the shared_image_gallery_destination block, and the convert-os-disk-snapshot-to-sig.sh file was modified to be used with all VHDs by assigning the architecture property dynamically and enabling shallow replication. Additionally, the deis/go-dev container needed to be reverted to v1.38.0.

Further details regarding these changes can be found in the project presentation.

Which issue(s) this PR fixes:

Unsatisfactory VHD Build Times.

Requirements:

zachary-bailey avatar May 03 '24 15:05 zachary-bailey

Pull Request Test Coverage Report for Build 8941547289

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 76.258%

Totals Coverage Status
Change from base Build 8931627929: 0.0%
Covered Lines: 3000
Relevant Lines: 3934

💛 - Coveralls

coveralls avatar May 03 '24 15:05 coveralls

Obsolete PR.

zachary-bailey avatar Jul 25 '24 17:07 zachary-bailey