feat: Don't set feature gate CustomCPUCFSQuotaPeriod, Get them from kubelet configs
What type of PR is this?
/kind feature
What this PR does / why we need it:
Currently, if CPUCFSQuotaPeriod are set in CustomKubeletConfigs, agent baker set feature gates "CustomCPUCFSQuotaPeriod =true", this PR removes this logic since the feature gate is already set by RP.
Which issue(s) this PR fixes:
Fixes #
Requirements:
- [ ] uses conventional commit messages
- [ ] includes documentation
- [ ] adds unit tests
- [ ] tested upgrade from previous version
Special notes for your reviewer:
Release note:
none
Pull Request Test Coverage Report for Build 9966808887
Details
- 0 of 0 changed or added relevant lines in 0 files are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage decreased (-0.02%) to 71.005%
| Totals | |
|---|---|
| Change from base Build 9966582612: | -0.02% |
| Covered Lines: | 2564 |
| Relevant Lines: | 3611 |
💛 - Coveralls
we should probably wait on merging on this until the RP change has rolled out to all regions, otherwise we'll risk those feature gates not getting properly set
also we don't generally link to ADO PRs and things of that nature here since this is OSS :)
Yes this one should wait for the RP change.
The RP change has already rolled out to all regions, now we can merge this, @cameronmeissner could you help to review again?
The RP change has already rolled out to all regions, now we can merge this, @cameronmeissner could you help to review again?
do we still want/need to merge this?
The RP change has already rolled out to all regions, now we can merge this, @cameronmeissner could you help to review again?
do we still want/need to merge this?
Hi @cameronmeissner yes it's still needed.