AgentBaker icon indicating copy to clipboard operation
AgentBaker copied to clipboard

Removing go-bindata for embed

Open element-of-surprise opened this issue 10 months ago • 2 comments

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

It removes go-bindata for the built in embed.FS

This deletes thetemplate package for the parts package. Due to how embed works, it makes more sense to have a new package above the actual templates instead of another directory.

This removes complexity with two makefiles, removes the need to install a binary and run said generator. Instead, everything is moved into the standard compile phase.

gobind hasn't been updated in 4 years, which could be a sign of stability, however the master branch has been failing to build for 2 years.

Requirements:

Special notes for your reviewer: Might want to check my MAKEFILE changes with a skeptical eye, as I don't do makefiles since like the early 2000s.

I modified one of the templates to remove ^M, which is a line ending for windows.

Release note:

none

element-of-surprise avatar Mar 27 '24 21:03 element-of-surprise