AgentBaker icon indicating copy to clipboard operation
AgentBaker copied to clipboard

feat: add node graceful shutdown kubelet config

Open weichch opened this issue 1 year ago • 3 comments

What type of PR is this?

/kind feature /kind api-change

What this PR does / why we need it:

This PR adds node graceful shutdown Kubelet config items and exposes those for client use, so that we can allow customers to enable this feature on their nodes.

This PR is recreated from the previous PR (#4147) from fork as per comment.

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none

weichch avatar Mar 11 '24 22:03 weichch

Pull Request Test Coverage Report for Build 8318498735

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 79.385%

Totals Coverage Status
Change from base Build 8304229022: 0.04%
Covered Lines: 2299
Relevant Lines: 2896

💛 - Coveralls

coveralls avatar Mar 11 '24 22:03 coveralls

As per mentioned in #4147, the feature gate is by default enabled in all k8s versions we currently support.

weichch avatar Mar 11 '24 22:03 weichch

I'm putting this on hold now as there might be some investigations I need to do before this can be merged.

weichch avatar Mar 18 '24 20:03 weichch

@weichch closing for now due to inactivity, feel free to reopen when needed

cameronmeissner avatar Aug 28 '24 21:08 cameronmeissner