AgentBaker icon indicating copy to clipboard operation
AgentBaker copied to clipboard

feat: support skipping legacy code CleanupHnsNetwork in AKS Windows CSE

Open ShiqianTao opened this issue 1 year ago • 4 comments

What type of PR is this? /kind feature

What this PR does / why we need it:

  • kube-proxy upstream has the code for waiting azure network which supported 1.22+
  • kube-proxy upstream has the code for cleaning HNS policy which supported 1.21+
  • Retain HNS network which confirmed by Windows team and Upstream team
  • Reuse toggle NotRebootWindowsNode to control it by PR https://github.com/Azure/AgentBaker/pull/4103

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none

ShiqianTao avatar Mar 01 '24 15:03 ShiqianTao

Pull Request Test Coverage Report for Build 8771032820

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.148%

Totals Coverage Status
Change from base Build 8761262511: 0.0%
Covered Lines: 2414
Relevant Lines: 3050

💛 - Coveralls

coveralls avatar Mar 01 '24 15:03 coveralls

lgtm

daschott avatar Mar 19 '24 14:03 daschott

LGTM

marosset avatar Mar 19 '24 16:03 marosset

cc @sbangari

daschott avatar Mar 27 '24 20:03 daschott