Azure
perf: Parallelize downloadContainerdWasmShims function / fix download error bug
What type of PR is this?
/kind performance
What this PR does / why we need it:
This PR changes the execution of downloadContainerdWasmShims to make use of parallel processing. It increases the speed of the function by 2 minutes on average.
Which issue(s) this PR fixes:
This is one of a variety of incremental performance improvements that will ultimately increase the speed of VHD Build times.
Requirements:
- [ ] uses conventional commit messages
- [ ] includes documentation
- [ ] adds unit tests
- [ ] tested upgrade from previous version
Pull Request Test Coverage Report for Build 8653558851
Details
- 0 of 0 changed or added relevant lines in 0 files are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage remained the same at 79.266%
| Totals | |
|---|---|
| Change from base Build 8652187564: | 0.0% |
| Covered Lines: | 2355 |
| Relevant Lines: | 2971 |
💛 - Coveralls
@Mossaka Good morning,
I am the engineer working with @ganeshkumarashok to decrease VHD build times in our pipelines.
Can you review this PR and let me know what you think? I removed v0-3-0 and v0-5-1 in baker.go, baker_test.go, and the cse_install.sh file. This is meant to be a fix until the appropriate versions can be put in. Additionally, I am running the downloadContainerdWasmShims function in parallel now in order to increase speed. It passed in the VHD Build Test pipeline with no errors.
The way the function and configs are currently written, the function fails for 5 minutes while it attempts to download wws-shims for v0-3-0 and v0-5-1. Please let me know if you have an input or suggestions! Thanks.
Also @zachary-bailey, could you change the PR title to mention the deletion of the older version too, if you decide to keep both deletion and parallelization in the same PR?
Agentbaker e2e docs for testing further: https://github.com/Azure/AgentBaker/tree/master/e2e