Azure
feat. add check to enable disabling secure boot for windows nodes
- For testing drivers w/ windows secure boot must be disabled
What type of PR is this? /kind feature
What this PR does / why we need it: Adds an env var check in windows/e2e-scenario.sh in order to disable secure boot. In order to test unsigned Windows Drivers secure boot must be disabled.
- Windows Org locks down being able to create signed drivers, meaning to evaluate and test windows drivers secure boot must be disabled so that installing unsigned drivers can be setup.
Which issue(s) this PR fixes:
Fixes #3677
Requirements:
- [x] uses conventional commit messages
- [ ] includes documentation
- [ ] adds unit tests
- [ ] tested upgrade from previous version
Special notes for your reviewer:
Release note:
none
Pull Request Test Coverage Report for Build 9586893073
Details
- 0 of 0 changed or added relevant lines in 0 files are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage remained the same at 75.969%
| Totals | |
|---|---|
| Change from base Build 9586608818: | 0.0% |
| Covered Lines: | 2627 |
| Relevant Lines: | 3458 |
💛 - Coveralls
@juliusl Thanks for the PR. Do you only want to disable secure boot for Windows nodes in AgentBaker e2e tests? If so, your PR looks good.
- One required test failed because the PR/commit message does not follow the commit message lint. You need to update
feat.tofeat: - E2E tests only can be run when you create the PR from a branch in Azure/AgentBaker but not a forked repo. You can ping me in teams so I can guide you how to request the permission.
@juliusl Thanks for the PR. Do you only want to disable secure boot for Windows nodes in AgentBaker e2e tests? If so, your PR looks good.
@AbelHu Finally getting back around to this, yes I only want to be able to do this in e2e tests