AgentBaker icon indicating copy to clipboard operation
AgentBaker copied to clipboard

one linux VHD build mode, eliminate gen1, gen2, and sig modes for linux VHD builds

Open cameronmeissner opened this issue 3 years ago • 1 comments

What this PR does / why we need it:

  • Merged gen1, gen2, and sig modes into one linuxVhdMode for Linux VHD builds
  • Windows VHD builds will maintain their current state and retain all three original modes
  • We now build MarinerV1 Gen1 VHD images from a marketplace base image instead of a pre-supplied VHD blob
  • All Linux VHD builds through packer will now output a managed image which then gets published to a SIG version

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none

cameronmeissner avatar Oct 13 '22 21:10 cameronmeissner

@wanqingfu could you help to review this PR to make sure that Windows SIG build and GEN2 build still work with this change?

AbelHu avatar Oct 21 '22 02:10 AbelHu

I've gone through all the file changes. This PR is compatible with WINDOWS SIG build and GEN2 build @AbelHu. For the windows part changes, they are basically only renaming the GEN2_CAPTURED_SIG_VERSION to CAPTURED_SIG_VERSION - functionality remains the same.

Confirmed with @cameronmeissner and will continue to follow up on this. I've been monitoring the pipeline also, and I don't think I'm seeing any fail in most recent runs relating to this PR.

wanqingfu avatar Oct 24 '22 07:10 wanqingfu