AgentBaker
AgentBaker copied to clipboard
add moby-cli and moby-engine to containerd vhd, no longer build docker vhds
What type of PR is this?
What this PR does / why we need it: This PR brings in changes to the VHD build process. We're now installing moby-cli and moby-engine when building containerd VHDs so we no longer need to build independent docker-based VHDs, which are no longer being built also as a part of these changes.
Requirements:
- [ ] uses conventional commit messages
- [ ] includes documentation
- [ ] adds unit tests
- [ ] tested upgrade from previous version
Special notes for your reviewer:
Release note:
none
should update this bit to force both? https://github.com/Azure/AgentBaker/blob/0b9d929a71b540a72040e69534bbf6503cf99f96/parts/linux/cloud-init/artifacts/cse_main.sh#L181-L185
should update this bit to force both?
https://github.com/Azure/AgentBaker/blob/0b9d929a71b540a72040e69534bbf6503cf99f96/parts/linux/cloud-init/artifacts/cse_main.sh#L181-L185
I figured these two would clash if they both ran, I guess that's not the case?
right now they disable each other, I think we can just merge the logic. (update the impls to avoid disabling each other, and then always run both // or similar)
as-is, when we boot up the containerd vhd, dockerd will get disabled, so we can't share the vhd :D
as-is, when we boot up the containerd vhd, dockerd will get disabled, so we can't share the vhd :D
I guess that's not true since it will come from RP, so maybe this is fine...let me marinate on that
so...installStandaloneContainerd will install it, but then ensureContainerd would remove it for docker vhd... ensure docker would remove containerd tho...actually not even sure how that works right now? I suppose docker might be running its own containerd daemon, not a separate unit.
I think if we actually want to use the containerd unit we install, we should always manually be installing both containerd and docker like in installStandaloneContainerd, and ensureDocker/ensureContainerd should not remove their counterparts? I think as is this should work because docker runs containerd itself, but it's a little circular
but then it might make sense to merge a bit more code...