ALZ-Bicep icon indicating copy to clipboard operation
ALZ-Bicep copied to clipboard

💡 Feature Request - Update Resource Group Names From `POC`

Open jtracey93 opened this issue 3 years ago • 1 comments
trafficstars

Describe the solution you'd like

In some of our module docs we need to create Resource Groups to deploy resources into. Today some of the Resource Group Names have references to POC etc. in them which we should change to something that aligns more to what we'd normally expect to see in a normal "production" deployment.

Some examples of POC nomenclature and differences in modules:

  • https://github.com/Azure/ALZ-Bicep/tree/main/infra-as-code/bicep/modules/spokeNetworking#deployment
  • https://github.com/Azure/ALZ-Bicep/tree/main/infra-as-code/bicep/modules/hubNetworking#deployment
  • https://github.com/Azure/ALZ-Bicep/tree/main/infra-as-code/bicep/modules/logging#deployment

As you can see in the community create hubPeeredSpoke module there is a good example of the resource group name being changed from POC: https://github.com/Azure/ALZ-Bicep/blob/main/infra-as-code/bicep/orchestration/hubPeeredSpoke/hubPeeredSpoke.bicep#L28

Describe alternatives you've considered

N/A

Additional context

  • Try to follow CAF naming recommendations and standards: https://docs.microsoft.com/en-us/azure/cloud-adoption-framework/ready/azure-best-practices/resource-abbreviations
  • Update pipelines and other places old Resource Group Names are used as well as modules and their docs
  • Review limits on Resource Group naming here: https://docs.microsoft.com/en-us/azure/azure-resource-manager/management/resource-name-rules#microsoftresources

Naming Pattern Suggestion

rg-${parTopLevelManagementGroupPrefix}-hub-networking-prod-001 - Hub Networking Resource Group rg-${parTopLevelManagementGroupPrefix}-logging-auto-prod-001 - Logging Resource Group

jtracey93 avatar Jul 19 '22 11:07 jtracey93

This is linked to PR #312

jtracey93 avatar Sep 07 '22 19:09 jtracey93

#312 closes this

jtracey93 avatar Nov 03 '22 08:11 jtracey93