2020-machine-learning-security-evasion-competition icon indicating copy to clipboard operation
2020-machine-learning-security-evasion-competition copied to clipboard

Published 20 hours ago • verified publisher icon Azure

Temp fix for #6

Open trympet opened this issue 4 years ago • 4 comments

Prevents errors being thrown when getting heater status while the "heater" object is missing. This is not a permanent fix, as the accessory will always be shown as OFF. However, this allows the user to turn the heater on or off, albeit with incorrect status reporting.

trympet avatar Aug 23 '20 14:08 trympet

Also, it appears that only NA is affected by this.

trympet avatar Aug 23 '20 14:08 trympet

It’s weird that the heater object is simply not in the response. Not sure how the official Volvo app is getting that info.. 🤔

GH-25 fixes the issue with features not being hidden. Maybe we can revise the temp fix by using that change and then disabling preclimatization by default?

drakkhen avatar Sep 11 '21 13:09 drakkhen

GH-25 fixes the issue with features not being hidden. Maybe we can revise the temp fix by using that change and then disabling preclimatization by default?

Good idea. Up for grabs! 😄

trympet avatar Sep 12 '21 15:09 trympet

Created PR-27 which -- I think -- should disable the preclimatization feature by default on fresh installs.

drakkhen avatar Sep 12 '21 21:09 drakkhen