ms-identity-javascript-react-tutorial icon indicating copy to clipboard operation
ms-identity-javascript-react-tutorial copied to clipboard

Update 3.1 to follow BASHER and Zero Trust guidelines

Open derisen opened this issue 3 years ago • 1 comments

Purpose

  • Update sample 3-1 to follow BASHER guidelines

Does this introduce a breaking change?

[ x ] Yes
[ ] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ x ] Feature
[ ] Code style update (formatting, local variables)
[ x ] Refactoring (no functional changes, no api changes)
[ x ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
git clone https://github.com/Azure-Samples/ms-identity-javascript-react-tutorial.git
cd ms-identity-javascript-react-tutorial
git checkout basher-3-1

cd 3-Authorization-II/1-call-api/SPA
npm install
npm start

cd 3-Authorization-II/1-call-api/API
npm install
npm start

If you like to test the API in this sample with application permissions, you can use the client-credentials sample here (branch: basher-test)

derisen avatar Jun 17 '22 22:06 derisen

Aside from a few nits LGTM

v-michaelmi avatar Jun 21 '22 22:06 v-michaelmi

closing this in favor of #142 cc @kalyankrishna1

derisen avatar Sep 01 '22 00:09 derisen