container-apps-store-api-microservice icon indicating copy to clipboard operation
container-apps-store-api-microservice copied to clipboard

Change private registry to false so it works with GitHub/Container Apps Tutorial

Open DanWahlin opened this issue 3 years ago • 0 comments

Purpose

  • Currently this repo will fail when deployed using the GitHub Actions tutorial at https://learn.microsoft.com/en-us/azure/container-apps/dapr-github-actions?tabs=bash. This fixes that issue by setting the GitHub registry to public in the bicep files.

Does this introduce a breaking change?

[ ] Yes
[X ] No

Pull Request Type

What kind of change does this Pull Request introduce?

Updates a single line in deploy/main.bicep. Currently the GitHub tutorial at https://learn.microsoft.com/en-us/azure/container-apps/dapr-github-actions?tabs=bash uses this repo to demonstrate GitHub Actions and Azure Container Apps. However, the deploy/main.bicep marks the GitHub registry for the package as true but it looks like that should be false.

This PR changes isPrivateRegistry to false in deploy/main.bicep.

[ X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Run the tutorial at https://learn.microsoft.com/en-us/azure/container-apps/dapr-github-actions?tabs=bash but use this PR for the repo (or update main.bicep as mentioned above). The container app revision that is created should now be able to pull the image needed and load successfully in the browser.

What to Check

  • After going through the https://learn.microsoft.com/en-us/azure/container-apps/dapr-github-actions?tabs=bash tutorial you should be able to load the node-app UI successfully.

DanWahlin avatar Sep 19 '22 05:09 DanWahlin