feat: Support rbac auth type in conversation_logger
Purpose
- To support rbac when conversation history is being saved
Does this introduce a breaking change?
- [ ] Yes
- [x] No
How to Test
- Run it in devcontainer to test
git clone [[repo-address]](https://github.com/leonavevor/chat-with-your-data-solution-accelerator)
cd chat-with-your-data-solution-accelerator
git checkout main
- Test the code
code/tests/utilities/helpers/test_azure_search_helper.py => test_get_conversation_logger_rbac()
What to Check
Verify that the following are valid
- should be able to have your conversations saved even if you are not using key based auth (i.e using RBAC).
Other Information
@microsoft-github-policy-service agree
Coverage Report •
File Stmts Miss Cover Missing code/backend/batch/utilities/helpers azure_search_helper.py 59 1 98% 269 TOTAL 3821 858 77%
| Tests | Skipped | Failures | Errors | Time |
|---|---|---|---|---|
| 395 | 0 :zzz: | 0 :x: | 0 :fire: | 52.293s :stopwatch: |
@Prasanjeet-Microsoft and @Vinay-Microsoft I have committed a better fix for this issue and rebased my recent changes on it, so it is in sync with the upstream main. This fix is base on AzureSearch library. This is the new change: https://github.com/Azure-Samples/chat-with-your-data-solution-accelerator/pull/1627/commits/92e7f9847e7b00ae277e1191c2d1acb45d3c1dbb
@Prasanjeet-Microsoft and @Vinay-Microsoft I have committed a better fix for this issue and rebased my recent changes on it, so it is in sync with the upstream main. This fix is base on AzureSearch library. This is the new change: 92e7f98
Hello @leonavevor, Thanks for the updated fix and for incorporating the changes using the AzureSearch library. We will verify the changes and if everything works as expected, we will proceed with merging the PR.