chat-with-your-data-solution-accelerator icon indicating copy to clipboard operation
chat-with-your-data-solution-accelerator copied to clipboard

feat: Support rbac auth type in conversation_logger

Open leonavevor opened this issue 11 months ago • 2 comments

Purpose

  • To support rbac when conversation history is being saved

Does this introduce a breaking change?

  • [ ] Yes
  • [x] No

How to Test

  • Run it in devcontainer to test
git clone [[repo-address]](https://github.com/leonavevor/chat-with-your-data-solution-accelerator)
cd chat-with-your-data-solution-accelerator
git checkout main
  • Test the code
code/tests/utilities/helpers/test_azure_search_helper.py => test_get_conversation_logger_rbac()

What to Check

Verify that the following are valid

  • should be able to have your conversations saved even if you are not using key based auth (i.e using RBAC).

Other Information

leonavevor avatar Jan 14 '25 14:01 leonavevor

@microsoft-github-policy-service agree

leonavevor avatar Jan 14 '25 15:01 leonavevor

Coverage

Coverage Report •
FileStmtsMissCoverMissing
code/backend/batch/utilities/helpers
   azure_search_helper.py59198%269
TOTAL382185877% 

Tests Skipped Failures Errors Time
395 0 :zzz: 0 :x: 0 :fire: 52.293s :stopwatch:

github-actions[bot] avatar Jan 16 '25 10:01 github-actions[bot]

@Prasanjeet-Microsoft and @Vinay-Microsoft I have committed a better fix for this issue and rebased my recent changes on it, so it is in sync with the upstream main. This fix is base on AzureSearch library. This is the new change: https://github.com/Azure-Samples/chat-with-your-data-solution-accelerator/pull/1627/commits/92e7f9847e7b00ae277e1191c2d1acb45d3c1dbb

leonavevor avatar Jun 05 '25 10:06 leonavevor

@Prasanjeet-Microsoft and @Vinay-Microsoft I have committed a better fix for this issue and rebased my recent changes on it, so it is in sync with the upstream main. This fix is base on AzureSearch library. This is the new change: 92e7f98

Hello @leonavevor, Thanks for the updated fix and for incorporating the changes using the AzureSearch library. We will verify the changes and if everything works as expected, we will proceed with merging the PR.

Prasanjeet-Microsoft avatar Jun 11 '25 05:06 Prasanjeet-Microsoft