azure-search-openai-demo-csharp
azure-search-openai-demo-csharp copied to clipboard
KeyVault secrets are passed to module w/o `secure()` decorator.
This app creates secrets in bulk, but passes those secrets from main.bicep w/o using the secure decorator. Those secrets with therefore be in plaintext in the Azure deployment.
Add secure()
here.
https://github.com/Azure-Samples/azure-search-openai-demo-csharp/blob/fb1ca3248e693ea7acb04740c97526c5a49c82eb/infra/core/security/keyvault-secrets.bicep#L3
If that isn't possible, then remove the keyvault-secrets.bicep file and create them with individual module references and a secure
decorator on the key.
@jongio Can you share an example on adding secure decorator to individual module?
I'd go this route:
If that isn't possible, then remove the keyvault-secrets.bicep file and create them with individual module references and a secure decorator on the key.
I'd go this route:
If that isn't possible, then remove the keyvault-secrets.bicep file and create them with individual module references and a secure decorator on the key.
@jongio do we have a sample of this?
@LittleLittleCloud are we okay to close this one?
I'd remove "secrets" file and set each one individually so they are passed securely.