Don't app-silo outgoing viewing keys anymore

[nventuro]

Check with @benesjan whether this can be actually done.

[benesjan]

It is still done. In all the constrained callsites we get the ovsk_app via this function on private context. Unconstrained callsites use this getter.

[nventuro]

I think my comment was referencing the fact that someone (@sklppy88?) mentioned they thought you had found an issue with the removal of this siloing, and that you had said we could not get rid of it.

[sklppy88]

I think we should talk more about this yes, I don't fully remember what was said but I do remember there was discussions on this and a difference between removing the app-siloing of the ivsk and ovsk. I think that before the ivsk_app was non-hardened, whereas the ovsk-app currently is hardened, maybe it had something to do with that ? I'll try to remember more what exactly it had to deal with.

[iAmMichaelConnor]

Outgoing keys have been removed from aztecnr. They still exist in the preimage of an address, but aren't currently used. Therefore, closing this issue.