refactor: updated NFT flows

Open benesjan opened this issue 1 year ago • 2 comments

Updating NFT flows based on the knowledge gained at offsite.

Oct 10 '24 12:10 benesjan

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @benesjan and the rest of your teammates on Graphite

Oct 10 '24 12:10 benesjan

Changes to public function bytecode sizes

Generated at commit: 44af19c6625363565a004c7d3d28a7f09380af09, compared to commit: c7d4572b49b33ee309f9238f3cec245878e6c295

Program	Bytecode size in bytes (+/-)	%
NFT::public_dispatch	+31 ❌	+0.14%
NFT::finalize_transfer_to_private	-1,574 ✅	-30.11%

Full diff report 👇

Program	Bytecode size in bytes (+/-)	%
NFT::public_dispatch	21,559 (+31)	+0.14%
NFT::finalize_transfer_to_private	3,653 (-1,574)	-30.11%

Oct 10 '24 16:10 github-actions[bot]

Oct 24, 10:07 AM EDT: A user started a stack merge that includes this pull request via Graphite.
Oct 24, 10:10 AM EDT: Graphite couldn't merge this PR because it had conflicts with the trunk branch.

Oct 24 '24 14:10 benesjan