aztec-packages icon indicating copy to clipboard operation
aztec-packages copied to clipboard

Determine max note len in pxe and nr

Open nventuro opened this issue 7 months ago • 2 comments

https://github.com/AztecProtocol/aztec-packages/pull/14595 introduced NoteValidationRequest, which contains MAX_PACKED_NOTE_LEN. Unfortunately, we also need this value in TS, but said constant is highly aztec-nr specific. Is this a problem? Should we use a larger value (e.g. up to the size of the private log)? Do we not care?

nventuro avatar May 29 '25 18:05 nventuro

The same happened in #14634 for MAX_EVENT_SERIALIZED_LEN.

nventuro avatar Jun 03 '25 16:06 nventuro

@mverzilli just wasted a lot of time due to this hardcoded constant. Sad

benesjan avatar Nov 18 '25 16:11 benesjan

Now I have wasted a lot of time on this. Seeing this a week ago makes me feel like an absolute retard

benesjan avatar Nov 27 '25 18:11 benesjan