AztecProtocol
feat: deriving serialization in protocol circuits
Until now using #[derive(Deserialize, Serialize, ...)] in noir protocol circuits didn't work because we had an issue with ordering in the types crate.
WHY BLOCKED? WEN MERGE?
Currently blocked by https://github.com/noir-lang/noir/issues/8545#issuecomment-2887599812
Note: If this PR gets merged this PR from Alvaro can most likely be closed.
-
#11041
-
#11774 👈 (View in Graphite)
-
master
This stack of pull requests is managed by Graphite. Learn more about stacking.
Changes to public function bytecode sizes
Generated at commit: 22a230ffbc8ab76ee9e2807a6b302c0a6dfec184, compared to commit: 4f6b76f2a19808b3786bf7a7dee96a126c770d69
🧾 Summary (100% most significant diffs)
| Program | Bytecode size in bytes (+/-) | % |
|---|---|---|
| Lending::init | +190 ❌ | +6.96% |
| AMM::constructor | +190 ❌ | +6.11% |
| AppSubscription::constructor | +190 ❌ | +5.30% |
| FPC::constructor | +145 ❌ | +4.85% |
| Crowdfunding::init | +145 ❌ | +4.64% |
| AppSubscription::public_dispatch | +190 ❌ | +4.02% |
| Crowdfunding::public_dispatch | +145 ❌ | +3.27% |
| CardGame::on_game_joined | +145 ❌ | +2.76% |
| CardGame::on_card_played | +145 ❌ | +2.26% |
| CardGame::start_game | +145 ❌ | +2.06% |
| CardGame::on_cards_claimed | +145 ❌ | +1.87% |
| FPC::public_dispatch | +145 ❌ | +1.39% |
| CardGame::public_dispatch | +145 ❌ | +0.95% |
| AMM::public_dispatch | +190 ❌ | +0.72% |
| Lending::public_dispatch | +190 ❌ | +0.69% |
| EasyPrivateVoting::public_dispatch | +5 ❌ | +0.10% |
Full diff report 👇
| Program | Bytecode size in bytes (+/-) | % |
|---|---|---|
| Lending::init | 2,919 (+190) | +6.96% |
| AMM::constructor | 3,301 (+190) | +6.11% |
| AppSubscription::constructor | 3,777 (+190) | +5.30% |
| FPC::constructor | 3,137 (+145) | +4.85% |
| Crowdfunding::init | 3,268 (+145) | +4.64% |
| AppSubscription::public_dispatch | 4,921 (+190) | +4.02% |
| Crowdfunding::public_dispatch | 4,575 (+145) | +3.27% |
| CardGame::on_game_joined | 5,390 (+145) | +2.76% |
| CardGame::on_card_played | 6,560 (+145) | +2.26% |
| CardGame::start_game | 7,193 (+145) | +2.06% |
| CardGame::on_cards_claimed | 7,900 (+145) | +1.87% |
| FPC::public_dispatch | 10,554 (+145) | +1.39% |
| CardGame::public_dispatch | 15,379 (+145) | +0.95% |
| AMM::public_dispatch | 26,656 (+190) | +0.72% |
| Lending::public_dispatch | 27,910 (+190) | +0.69% |
| EasyPrivateVoting::public_dispatch | 4,836 (+5) | +0.10% |
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
WHY BLOCKED? WEN MERGE?
Currently blocked by https://github.com/noir-lang/noir/issues/8545#issuecomment-2887599812
Issue fixed. Wen merge?
Issue fixed. Wen merge?
@jfecher Just came back from vacation. Will try to resurrect this.