Fantasy-Map-Generator
Fantasy-Map-Generator copied to clipboard
Add shell script to launch local HTTP server and open browser (GNU/Linux)
Description
Added a shell script (run_python_server.sh) that launches a local HTTP server using Python3 or Python package and automatically opens Firefox browser to http://localhost:8000.
Type of change
- [ ] Bug fix
- [X] New feature
- [ ] Refactoring / style
- [ ] Documentation update / chore
- [ ] Other (please describe)
Versioning
- [ ] Version is updated
- [ ] Changed files hash is updated
Deploy Preview for afmg ready!
| Name | Link |
|---|---|
| Latest commit | 7e78f5e550805fa5035e9e470d40047db4d3d38d |
| Latest deploy log | https://app.netlify.com/projects/afmg/deploys/68548817a3bc3a0008cb2bc8 |
| Deploy Preview | https://deploy-preview-1212--afmg.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify project configuration.
Why Firefox? It has very limited usage nowadays and also it's not the best browser for svg rendering, so our recommendation is to use Chrome.
My bad. Would the Chromium package be acceptable instead? Or do we need to use Google Chrome here to stick with the convention? It is possible to install Google Chrome on GNU/Linux, but since it's a proprietary browser, most repos don't include it by default. It's typically installed by using Google's binaries. Chromium is its free (MIT license) version also developed by Google, and is more widely available by default in GNU/Linux distributions and its repos, often installed as default web browser.
You can use any modern browser, but the tool works the best in Chrome. We just don't need to add a script to the repo, you can keep it locally, it doesn't have to be there at all.
Does this software rely on any features exclusive to Google Chrome that aren't available in pure Chromium? I also believe that adding this script will be beneficial for users. When I tried to run the project myself, I noticed there's a .bat file for Windows users, but no equivalent .sh script for GNU/Linux. Of course, running the program is simple, as it is a web application. But for someone unfamiliar with the setup process, the only guidance is buried in the wiki. Windows users, on the other hand, get a ready-to-use script that works out of the box (as long as you have a Google Chrome installed), without needing to write their own or search for documentation. I believe including a lightweight .sh script would be helpful. Especially since many web applications provides similar scripts.
I think FMG does not rely on any features exclusive to Google Chrome that aren't available in pure Chromium.
I also think having a lightweight .sh script would be helpful.