Baubles icon indicating copy to clipboard operation
Baubles copied to clipboard

OnUnequipped is called too early when switching out a bauble with another one

Open ochotonida opened this issue 6 years ago • 0 comments

When switching out baubles by putting another stack in a bauble slot already containing an item, onUnequipped for the bauble already in the slot gets called before the item is actually removed from the slot. This is not the case when unequipping baubles the normal way.

This is a problem for baubles that both

  • apply their effects only when equipping/unequipping
  • can be placed in multiple slots (rings/trinkets or multiple different baubles that have the same effect)

as they should check if a bauble of that type is still equipped before removing the effect in onUnequipped. Using this bug, it is possible to retain the effect of such baubles without actually wearing them by switching them out with another item.

ochotonida avatar Feb 14 '19 15:02 ochotonida