Ayushi Daksh
Ayushi Daksh
@wkerzendorf In case of Custom packet source, do we really want to force the user to take in quantities with units and return quantities with units?
Hi @Rodot- can I take this up? I see the earlier PR related to this issue was closed without merging.
@MarkMageeAstro @jamesgillanders Sorry I somehow saw the comments now. Yes we're keen on merging this. I'll rebase this branch and make the requested changes today
@MarkMageeAstro Sorry I moved to a new city this month so the last couple of weeks were really busy. I have started work on this now, will wrap it up...
> Minor changes to documentation. Should be good to merge after rebasing. Is that Grotrian mockup notebook still necessary? I have changed the docs according to the comments and rebased...
@MarkMageeAstro > One minor correction to documentation. Somehow I'm not able to see your comment. Can you point me to where you need the correction? > Also the mockup notebook...
> Hmm, I can't find it either. Must not have been that important. I did spot one other small thing when looking for it thoguh, sorry. No worries! I have...
Rebased with master and tested the widget locally again, all seems good. Please look at https://github.com/tardis-sn/tardis/pull/2328#issuecomment-1989679345 and let me know if anything else is pending here. Thanks!
Thanks @MarkMageeAstro ! @jamesgillanders Can you please review/approve so we can merge this? It was great working on this project with TARDIS. Feel free to tag me in future issues/enhacements...
@Soumya624 Are you still working on resolving this? If not, please let me know if I can take it forward from here.