jsoncrack.com icon indicating copy to clipboard operation
jsoncrack.com copied to clipboard

Collapse bug

Open AykutSarac opened this issue 2 years ago • 3 comments

    @AykutSarac The bug is present on `production` and is unrelated to this ticket.

I suggest opening a new issue for this bug.

https://user-images.githubusercontent.com/71708164/194141356-fcf6c181-f830-42a6-b5e7-49fcb3b77532.mov

You can reproduce it by using this JSON:

{ "test": "test", "members": [ { "test": "test", "members": [ { "test": "test", "members": [ { "test": "test", "members": [] } ] } ] } ] }

Originally posted by @VladCuciureanu in https://github.com/AykutSarac/jsoncrack.com/issues/230#issuecomment-1268835382

AykutSarac avatar Oct 15 '22 14:10 AykutSarac

Hey! I'd like to work on this!

mintbomb27 avatar Oct 15 '22 18:10 mintbomb27

@AykutSarac Is the expected working of this issue to expand all the children, or just expand till the next level of the graph?

mintbomb27 avatar Oct 16 '22 18:10 mintbomb27

@mintbomb27

  1. Use this json (or any depth >= 4 json): { "test": "test", "members": [ { "test": "test", "members": [ { "test": "test", "members": [ { "test": "test", "members": [] } ] } ] } ] }
  2. Close the graph nodes one by one, from leaf to root
  3. Expand the first node

At this point, in the video at 0:04, you can see other nodes appear besides the expected one (the disconnected node is not expected)

VladCuciureanu avatar Oct 17 '22 08:10 VladCuciureanu

@AykutSarac I've created PR #243 to fix this issue. Could you please take a look when you get some time.

shivam1646 avatar Oct 23 '22 09:10 shivam1646