jsoncrack.com
jsoncrack.com copied to clipboard
AykutSarac
Added 'url' query parameter for loading JSON files
Solves #149
This adds a way to load JSON files via the 'url' query parameter
Example:
/editor?url=http://ip.jsontest.com/
Can we make it to work on Widget page too? Also can we use fetch API instead of XMLHttpReqeust for more general convention?
Can we make it to work on Widget page too? Also can we use fetch API instead of XMLHttpReqeust for more general convention?
Done :)
Can we add a loading state and display the <Loading /> component while fetching data? (considering the fetch failing case)
Can we add a loading state and display the
<Loading />component while fetching data? (considering the fetch failing case)
Is something like this what you had in mind?
Can we add a loading state and display the
<Loading />component while fetching data? (considering the fetch failing case)Is something like this what you had in mind?
I couldn't view the link you sent but what I meant is similar to when you paste big json and it display's "Parsing JSON" screen. You can test it with https://www.reddit.com/r/all.json
Solves #149
This adds a way to load JSON files via the 'url' query parameter
Example:
/editor?url=http://ip.jsontest.com/
I create it in a PR #70 , but it is closed.
@AykutSarac I'm ok with either impl so it's up to you
I'm not a fan of creating new states honestly, so I'd go for this one as it's more up to date. Have you added the loading state yet?
@AykutSarac I'm ok with either impl so it's up to you
I'm not a fan of creating new states honestly, so I'd go for this one as it's more up to date. Have you added the loading state yet?
Yep. Ready for review/merge
Thanks for working on it, however this implementation does not satisfy with project and breaks its mechanism at some point, I think it's mostly because it does not have a proper documentation. I'll handle this at a new PR, thanks for the contribution! 🙂