jsoncrack.com icon indicating copy to clipboard operation
jsoncrack.com copied to clipboard

Feature Edit JSON in Diagram View

Open theogainey opened this issue 2 years ago • 8 comments

Description

Edit JSON in Diagram View

  • Enable editing JSON in graph nodes
  • Add Invalid JSON error to graph node modal containers
  • Add graph parser function to parse nodes into JSON

References Issue #147

theogainey avatar Oct 05 '22 02:10 theogainey

I updated this PR to work with the recent changes

theogainey avatar Oct 07 '22 01:10 theogainey

I've edited the "powers" key and it gotten a really weird structure. You've made an amazing work, but I think we should keep the PR open for a while for others to contribute to it. Graph to JSON is really hard and hard to implement because the parsing algorithm is also should be working perfectly to do the reverse parsing.

AykutSarac avatar Oct 10 '22 19:10 AykutSarac

@AykutSarac All that makes sense. Do you mind describing the weird behavior you're seeing so I can take a look at it. Also if there are any specific issues with the original parser that could use some work I would be interested in taking a look at it. This is cool project and I am planning on continuing to contribute to it if I can.

theogainey avatar Oct 10 '22 23:10 theogainey

Thanks for your interest in contributing @theogainey that's awesome! #27 and #51 are the highest priority issues of the parser exists since the first release. You can take a look to them if you have any idea on how to fix them.

AykutSarac avatar Oct 11 '22 05:10 AykutSarac

One of the weird behaiours I came across is when I edit the array/object key it gets into weird structure. You may work on it https://www.reddit.com/r/all.jsonhttps://www.reddit.com/r/all.json for a better workaround.

AykutSarac avatar Oct 11 '22 08:10 AykutSarac

Converting this PR to draft as it's currently not ready but could be improved and implemented in future.

AykutSarac avatar Oct 30 '22 10:10 AykutSarac

了不起!期待早日上线。

It's amazing and I'm looking forward to it.

iolh avatar Nov 18 '22 07:11 iolh

Please see #262 for additional ideas/options

NielsKorschinsky avatar Nov 23 '22 11:11 NielsKorschinsky

Thanks for your efforts, closing this PR as there's a better way to implement this using the Path to Node data.

AykutSarac avatar Mar 08 '23 09:03 AykutSarac