jsoncrack.com icon indicating copy to clipboard operation
jsoncrack.com copied to clipboard

Published 20 hours ago • verified publisher icon AykutSarac

[BUG]: incorrect Arrow Direction for 180° rotated representation

Open shripalmehta opened this issue 2 years ago • 4 comments

Issue description

The arrow directions for 180° rotated representation is messed up.

Refer image: Screenshot 2022-09-10 at 18 40 52

Media & Screenshots

No response

Operating system

  • OS: macOS v12.5.1
  • Browser: Safari v15.6.1 (17613.3.9.1.16)

Priority this issue should have

Low (slightly annoying)

shripalmehta avatar Sep 10 '22 13:09 shripalmehta

Good, that you find it

alicashelton avatar Sep 10 '22 18:09 alicashelton

Does it still occurs on your end?

AykutSarac avatar Oct 01 '22 15:10 AykutSarac

Does it still occurs on your end?

Yes. I tried to observe keenly and, only the arrow-heads on the straight lined arrows are wrong. The ones on the curved lines are correct.

shripalmehta avatar Oct 01 '22 19:10 shripalmehta

In my findings, the issue seems to be on safari's handling of marker-end + orient "auto" attribute value. Since fixing that on Safari-side would be a long process, I propose the fix in my pull request. I implement a custom arrow that rotates according to the layout rotation. Could this issue be marked for hacktoberfest? Thanks and hope it's useful.

Update: This issue will be handled on reaflow's side according to the discussion in #221

VladCuciureanu avatar Oct 03 '22 18:10 VladCuciureanu