practical-react-components icon indicating copy to clipboard operation
practical-react-components copied to clipboard

WIP: feat(slider): add fluent ui range slider

Open scharinger opened this issue 2 years ago • 1 comments

Describe your changes

Adding a new type of slider, RangeSlider, to next to Slider. It's directly imported from Fluent UI but uses a theme that is derived from the current theme provided by the practical theme context..

MicrosoftTeams-image

Checklist before requesting a review

  • [x] I have performed a self-review of my own code
  • [x] I have verified that the code builds perfectly fine on my local system
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have verified that my code follows the style already available in the repository
  • [ ] I have made corresponding changes to the documentation

scharinger avatar Mar 16 '22 18:03 scharinger

Is it needed to style it more to make it look and behave more like practical? If so, does someone have any suggestions on how to do this with fluent ui components?

scharinger avatar Mar 17 '22 07:03 scharinger