AxisCommunications
feat: es5 player example
This is very much untested code on my side, but it's based on @cwillison94 excellent effort in #459.
I don't have access to windows and IE11, so I'll take his word for it that this actually works.
Unfortunately I couldn't continue on his PR since he pushed it straight to master and I had no push rights there.
LGTM. @cwillison94 any review comment on this? If not then I can merge this.
I would rather see the original author in the commit, can you cherry-pick and add your changes on top @lekoaf ?
I would rather see the original author in the commit, can you cherry-pick and add your changes on top @lekoaf ?
I'm not sure. Can I? I started this PR because I couldn't add anything to @cwillison94 PR since he used his master branch instead of a feature branch.
Starting a new PR is no problem. But you can checkout someone's PR locally on a new branch, and then add new commits on top, and push as a new PR. That way, the original author will be also mentioned (but you will be the committer).
Something like:
git fetch https://github.com/cwillison94/media-stream-library-js.git d16fb67f9f80fdd655c3343c2608521139d0f246
git checkout -b es5-example FETCH_HEAD
Then add your changes on top as new commits, or even as amended commit (even then, author is preserved).
Since you already have the es5-example locally, you'll probably better save your stuff on a branch before doing this, like so:
git checkout es5-example
git checkout -b es5-example-backup
git fetch https://github.com/cwillison94/media-stream-library-js.git d16fb67f9f80fdd655c3343c2608521139d0f246
git checkout -B es5-example FETCH_HEAD