backstage-plugins icon indicating copy to clipboard operation
backstage-plugins copied to clipboard

Introduced TypeScript type definitions SearchJiraResponse and JiraQueryResults to represent Jira search responses and pagination details.

Open SaachiNayyer opened this issue 1 year ago • 8 comments

Introduced TypeScript type definitions SearchJiraResponse and JiraQueryResults to represent Jira search responses and pagination details. Updated the searchJira function to return search results as a SearchJiraResponse, incorporating the new types. Enhanced error handling in the searchJira function by handling HTTP response errors and logging them appropriately. The JiraQueryResults type outlines the structure of a paginated Jira search response, facilitating better data handling. These changes streamline the Jira Dashboard plugin's codebase, improving error resilience and clarity in handling search operations.

Describe your changes

Please include a summary of the change, a relevant motivation and context.

Issue ticket number and link

  • Fixes #(issue)

Checklist before requesting a review

  • [x] I have performed a self-review of my own code
  • [x] I have verified that the code builds perfectly fine on my local system
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have verified that my code follows the style already available in the repository
  • [x] I have made corresponding changes to the documentation

SaachiNayyer avatar May 13 '24 15:05 SaachiNayyer

🦋 Changeset detected

Latest commit: 7400858579d8c7fb3a2d6eb6d5dd3b902b862153

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@axis-backstage/plugin-jira-dashboard-backend Major
@axis-backstage/plugin-jira-dashboard-common Minor
@axis-backstage/plugin-jira-dashboard Minor
backend Patch
app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar May 13 '24 15:05 changeset-bot[bot]

Hi GLundh @anicke any thoughts or progress updates? for this PR Thanks

SaachiNayyer avatar May 15 '24 09:05 SaachiNayyer

Hi anicke Thanks for your comments. Have updated the PR with the changes. Request your review based on your availability and let me know if any further comments :)

SaachiNayyer avatar Jun 27 '24 15:06 SaachiNayyer

Hi anicke GLundh Just a gentle reminder :) I have resolved the given comments. Please let me know if you have any feedback/concerns based on your availability. Thanks

SaachiNayyer avatar Jul 02 '24 09:07 SaachiNayyer

Hi anicke GLundh Just a gentle reminder :) I have resolved the given comments. Its been a while for any update regarding this PR Please let me know if you have any feedback/concerns based on your availability. Thanks

SaachiNayyer avatar Sep 09 '24 13:09 SaachiNayyer

Hi anicke GLundh @fridajac Any update on this? As we need this PR merged urgently as we want to align our backstage plugins with opensource versions. And without this commit being merged we are blocked. Happy to discuss in case this commit is missing any functionality or further improvements. Also https://github.com/AxisCommunications/backstage-plugins/issues/177 is dependent on this PR to be merged. Appreciate your feedback based on your availability.

Thanks

SaachiNayyer avatar Sep 18 '24 15:09 SaachiNayyer

Hi @anicke Any feedback on my previous response. Please let us know your views based on your availability. Thanks

SaachiNayyer avatar Sep 30 '24 10:09 SaachiNayyer

@SaachiNayyer Please check my review and my requested changes.

anicke avatar Oct 04 '24 08:10 anicke

Please rebase so we can merge it.

anicke avatar Oct 15 '24 11:10 anicke

Please rebase so we can merge it.

Hi anicke Checks are failing due to installation of "@backstage/errors": "^1.2.4", as a dependency, I am not sure how to resolve the same. thanks

SaachiNayyer avatar Oct 29 '24 10:10 SaachiNayyer

If you run "yarn install" the "yarn.lock" file will be updated? If you just add the changes of the "yarn.lock" file to the PR?

anicke avatar Oct 29 '24 11:10 anicke

If you run "yarn install" the "yarn.lock" file will be updated? If you just add the changes of the "yarn.lock" file to the PR?

Thanks :)

SaachiNayyer avatar Oct 29 '24 12:10 SaachiNayyer