Axelrod icon indicating copy to clipboard operation
Axelrod copied to clipboard

Run black on all existing code

Open gaffney2010 opened this issue 4 years ago • 3 comments

If we're using black to format, I'd prefer to run on existing code. If we format as we go it can be harder to see why we're changing something. It caused me some merge conflicts when I ran black, changing lines, which were unchanged in origin, then were changed.

gaffney2010 avatar Apr 08 '20 09:04 gaffney2010

I'm in favour.

We can add a check to the CI to check all files are in the required format (for example: https://github.com/drvinceknight/Nashpy/blob/master/.github/workflows/config.yml#L34).

We'd need to add something to the contribution docs as well.

Something to consider though is the relatively massive PR that @marcharper has on the go #1288 this would potentially make that really painful to sort out so it could be worth doing after that goes in.

drvinceknight avatar Apr 08 '20 09:04 drvinceknight

Sounds good. I will work on after #1288 goes through.

gaffney2010 avatar Apr 08 '20 10:04 gaffney2010

#1288 is going to have a lot of merge conflicts anyway, and it's waiting on another PR, so feel free to work on whatever regardless.

marcharper avatar Apr 08 '20 15:04 marcharper