react-toolkit icon indicating copy to clipboard operation
react-toolkit copied to clipboard

Problem with peerDependencies

Open ulrik59 opened this issue 2 years ago • 0 comments

Issue and Steps to Reproduce

I'm currently using react-toolkit in its version 1.4.1 with react 17.0.2 and NodeJS 14 using npm version 6. When installing dependencies, I have the following warnings:

npm WARN [email protected] requires a peer of react@^16.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN [email protected] requires a peer of react-dom@^16.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN [email protected] requires a peer of react@^16.8.0 but none is installed. You must install peer dependencies yourself.
npm WARN [email protected] requires a peer of react-dom@^16.8.0 but none is installed. You must install peer dependencies yourself.

It seems that despite react-toolkit is declaring in its peer dependencies that it is supporting react 17, it is using dependencies which do not support officially it. Specifically, @axa-fr/react-toolkit-form-input-date is using an obsolete version of react-datepicker and @axa-fr/react-toolkit-form-input-select is using an obsolete version of react-select.

The solution would be to upgrade both of these dependencies.

Versions

1.4.0+

Expected

No peer dependencies warnings when installing dependencies with React 17

Actual

Warnings about react-datepicker and react-select not supporting React 17

Additional Details

  • NodeJS v14.19.1
  • Installed packages
    • react 17.0.2
    • react-dom 17.0.2

ulrik59 avatar May 30 '22 14:05 ulrik59