oidc-client
oidc-client copied to clipboard
Support lower version of Chrome
Hello, I wondered if there was any particular reason for service worker support to be limited to chrome version 90 or above?
I didn't think I could see anything that was dependent on the Chrome 90+ API, but I must admit I don't know the code base particularly well.
I wondered if it was possible to reduce the minimum version? In my use case either 70 or 87 would be great.
I'm happy to do the testing on the new minimum version if the change was acceptable.
https://github.com/AxaFrance/oidc-client/blob/bb7de0060ea81fa4206a5696a5479100f0c64898/packages/oidc-client/src/initWorker.ts#L168
Hi @nickwilliams-codynamic , there is no good reason for this lower.
I could not test on lower devices. So i set up this to auto fallback on classical mode.
I am on holiday for 3 weeks. But if you remove these line from a fork pullrequest. I will be able to merge it.
Hi @nickwilliams-codynamic ,
Version 3.7.2 authorize service worker until chrome 70 included. I am waiting for your feedback.
Hi @nickwilliams-codynamic , does it works for your with chrome 70?
Hi @guillaume-chervet sorry for the delay. Everything is working fine on Chrome 87, I will confirm for 70 tomorrow (AEST timezone).
Thank you @nickwilliams-codynamic for your feedback :)
Hi @nickwilliams-codynamic , does it work?
hi @nickwilliams-codynamic , any news on the subject?
Do you have any news @nickwilliams-codynamic ?
Hi @nickwilliams-codynamic , do you have any news? May i close the issue?
Hi @guillaume-chervet, I really sorry for how long it took me to get around to test this. Everything worked okay for me - although I had to build my own version as the change you made allowed going down to chrome version 71, but I needed 70.
if (name === 'chrome' && parseInt(version) <= 70) {
Everything work as expected, with the exception of the out of the box OidcServiceWorker.js
. That had some comparability issues, but it's not a big deal as it ends up as a file in the consumers repository anyway. I fix it by hand, but I suspect running it through babel would have worked too.
How @nickwilliams-codynamic , thank you for your feedback ! Did you need to fix some issue? Do we can make this repository code source better for your case?