oidc-client icon indicating copy to clipboard operation
oidc-client copied to clipboard

Support lower version of Chrome

Open nickwilliams-codynamic opened this issue 1 year ago • 11 comments

Hello, I wondered if there was any particular reason for service worker support to be limited to chrome version 90 or above?

I didn't think I could see anything that was dependent on the Chrome 90+ API, but I must admit I don't know the code base particularly well.

I wondered if it was possible to reduce the minimum version? In my use case either 70 or 87 would be great.

I'm happy to do the testing on the new minimum version if the change was acceptable.

https://github.com/AxaFrance/oidc-client/blob/bb7de0060ea81fa4206a5696a5479100f0c64898/packages/oidc-client/src/initWorker.ts#L168

nickwilliams-codynamic avatar Aug 14 '23 09:08 nickwilliams-codynamic

Hi @nickwilliams-codynamic , there is no good reason for this lower.

I could not test on lower devices. So i set up this to auto fallback on classical mode.

I am on holiday for 3 weeks. But if you remove these line from a fork pullrequest. I will be able to merge it.

guillaume-chervet avatar Aug 14 '23 14:08 guillaume-chervet

Hi @nickwilliams-codynamic ,

Version 3.7.2 authorize service worker until chrome 70 included. I am waiting for your feedback.

guillaume-chervet avatar Aug 15 '23 19:08 guillaume-chervet

Hi @nickwilliams-codynamic , does it works for your with chrome 70?

guillaume-chervet avatar Aug 17 '23 06:08 guillaume-chervet

Hi @guillaume-chervet sorry for the delay. Everything is working fine on Chrome 87, I will confirm for 70 tomorrow (AEST timezone).

nickwilliams-codynamic avatar Aug 17 '23 08:08 nickwilliams-codynamic

Thank you @nickwilliams-codynamic for your feedback :)

guillaume-chervet avatar Aug 17 '23 09:08 guillaume-chervet

Hi @nickwilliams-codynamic , does it work?

guillaume-chervet avatar Aug 23 '23 12:08 guillaume-chervet

hi @nickwilliams-codynamic , any news on the subject?

guillaume-chervet avatar Sep 05 '23 13:09 guillaume-chervet

Do you have any news @nickwilliams-codynamic ?

guillaume-chervet avatar Sep 14 '23 19:09 guillaume-chervet

Hi @nickwilliams-codynamic , do you have any news? May i close the issue?

guillaume-chervet avatar Oct 18 '23 10:10 guillaume-chervet

Hi @guillaume-chervet, I really sorry for how long it took me to get around to test this. Everything worked okay for me - although I had to build my own version as the change you made allowed going down to chrome version 71, but I needed 70.

 if (name === 'chrome' && parseInt(version) <= 70) {

Everything work as expected, with the exception of the out of the box OidcServiceWorker.js. That had some comparability issues, but it's not a big deal as it ends up as a file in the consumers repository anyway. I fix it by hand, but I suspect running it through babel would have worked too.

nickwilliams-codynamic avatar Oct 19 '23 21:10 nickwilliams-codynamic

How @nickwilliams-codynamic , thank you for your feedback ! Did you need to fix some issue? Do we can make this repository code source better for your case?

guillaume-chervet avatar Nov 12 '23 06:11 guillaume-chervet