synapse-admin icon indicating copy to clipboard operation
synapse-admin copied to clipboard

Federation page improvements

Open rkfg opened this issue 1 year ago • 7 comments

This PR hides zero last retry timestamps that are displayed as 1970/01/01 00:00:00 (misleading) and also improves the dark theme. Without this patch the white rows also have white text in them so the text is invisible unless you point at them, pink rows also have white text that's hard to read, and the reconnect button's color is too bright.

rkfg avatar Jul 18 '24 09:07 rkfg

Thanks for your contribution. Can you please post some pre and post screenshots, so that I get an impression what exactly is fixed?

awesome-manuel avatar Jul 18 '24 18:07 awesome-manuel

Sure, here's what it looks like now: 2024-07-18_21-27-04 and with the patch: 2024-07-18_21-27-41

Maybe the black background isn't the best choice and instead we should use the default from the theme?

rkfg avatar Jul 18 '24 18:07 rkfg

Yes, also instead of #ffcccc a theme color should be used.

awesome-manuel avatar Jul 18 '24 18:07 awesome-manuel

Setting the color to undefined (for the non-highlighted rows) is much better! 2024-07-18_21-39-10 I'm not sure what color to use from the theme.

rkfg avatar Jul 18 '24 18:07 rkfg

How about this? 2024-07-18_21-58-06 2024-07-18_21-58-01 I used the warning color from the theme and a slight button color correction. Without that it looks bad: 2024-07-18_21-59-00

rkfg avatar Jul 18 '24 18:07 rkfg

Alternatively, using the error color with lighten by 0.5 (otherwise it's too aggresively red): 2024-07-19_13-02-55 2024-07-19_13-02-49

Tell me what you prefer.

rkfg avatar Jul 19 '24 10:07 rkfg

Fixes:

  • #627

dklimpel avatar Oct 13 '24 11:10 dklimpel

can we merge this? 😎 the white theme burns my skin! ;)

jk779 avatar Nov 04 '24 13:11 jk779

It should now use the theme colors.

rkfg avatar Nov 04 '24 13:11 rkfg

looks good! :)

SCR-20241104-nyut

jk779 avatar Nov 04 '24 14:11 jk779