synapse-admin icon indicating copy to clipboard operation
synapse-admin copied to clipboard

Support bulk delete of user media

Open AverageMarcus opened this issue 4 years ago • 4 comments

Fixes #121

  • Adds multi-select to the user media list to allow for bulk deleting media.
  • For image types, a preview is also displayed in the list

Example:

Bulk delete media screenshot

Note: I've never used React before so not sure if the way I've implemented everything is the most ideal or not, would love any feedback.

AverageMarcus avatar Dec 26 '21 12:12 AverageMarcus

Thanks for the great feedback @dklimpel ! Hopefully addressed everything now.

CleanShot 2021-12-28 at 11 45 18

AverageMarcus avatar Dec 28 '21 11:12 AverageMarcus

I think the preview could be a violation of GDPR, right? Looking at private content uploaded by users e.g. in a private chat without their consent would be a violation unless the server's privacy policy explicitly says admins may look at for some given reasons.

WebFreak001 avatar Jan 21 '22 14:01 WebFreak001

Thats a good point @WebFreak001. I think the preview should not be displayed by default. Maybe there is a scenario where admins have to look into the images (e.g. when they were reported) but I also think that the users have to be aware that this is possible. Maybe the server should allow admins to read the images then. Would the preview even be available for pictures that were uploaded to encrypted rooms?

awesome-michael avatar Mar 22 '22 17:03 awesome-michael

Encrypted images does not match record.media_type.startsWith("image"). An admin can not read encrypted images.

e.g. image

dklimpel avatar Mar 22 '22 17:03 dklimpel

Any Update on that? Is there a possibility to shift + leftclick, so that you can select multiple tick-boxes at once?

jank04 avatar Dec 06 '23 16:12 jank04

Perhaps this could be in feature replaced by BulkUpdateFormButton.

dklimpel avatar Feb 03 '24 09:02 dklimpel

I think bulk delete is already available in the latest master. If this is only about image previews, please rename the PR.

awesome-manuel avatar Feb 07 '24 15:02 awesome-manuel