synapse-admin
synapse-admin copied to clipboard
Validate password field when re-enabling user accounts
If an administrator disables an account you can't re-enable it in synapse-admin version 0.8.0-12. It just says bad request. And their isn't anything in the output.
The problem seems to stem from synapse requiring the password to reactivate an account. So the password field needs to be made a required field when the deactivate switch is toggled to off. Then it appears that the deactivated state doesn't get reset because it still shows up as disabled after refreshing even though the account is active.
Can you discribe the steps what you do? I cannot reproduce it. Re-Activating a user works when you set a password and the list will be updated. There is also a hint for set a password.
It's not clear to the user that you need to put in the password to reactivate the account. This is the second time I've had to re-enable an account and both times I've forgotten it needs a password. IDK why it's not updating maybe my synapse is slow or something.
The steps I went through is accidentally disable your testing bots account from element. Then open synapse admin and toggle the disabled switch and hit save. Then wonder why your getting a 503 bad request error. Go ask around until you find the synapse admin docs that says it needs a password. Toggle the switch and put a password in. And then it works.
There is a hint right below the switch that says "You must provide a password to re-activate an account". How would you suggest to make it clearer that a password has to be set to re-activate an account?
I would suggest blocking the save button unless a password is given when the switch it turned back to the on position. I think you can make the password fiend red and shake. I just feel like it's not obvious enough. A user could be frustrated if they are trying to get in and out quickly and don't see the text below the button.