React-Pincode
React-Pincode copied to clipboard
Awesome-React-Modules
CSS modifications
Fixes #4
Changes done in this pull request:
Changed styling of the input fields
Files Added:
No new files added or removed. index.js and App.css files changed
Screenshots/Links:
System Information :
- OS: Windows
- Browser: Google Chrome
- Version: 81.0.4044.129 (Official Build) (64-bit)
Reviewers:
@AdityaSrivast Please review my PR. I made style changes for input fields and error dialog. Please let me know if I have to make any more further changes or improvements.
We appreciate you help towards improving the module, we look forward to having more contributions from your end
@AdityaSrivast Please review my PR. Please let me know if I have to improve anything.
@AdityaSrivast I made changes as you said. I removed the package-lock.json file, removed the line you said in package.json. And about the line that's commented, when I started to implement my styling I kinda commented it to check what I was doing. Its completely fine even if its not commented. Please review for any more changes and merge. Thank you!
@AdityaSrivast Can you merge this PR if there are no other changes or improvements required?
@Rukmini-Meda get rid of package-lock.json. Also if possible give any codesandbox, or jsfiddle link so that your implementation can be verified
@AdityaSrivast Can you help me with codesandbox? I imported my branch into it. But build/index.js shows many problems although it works fine in vscode. This is the link for codesandbox - https://codesandbox.io/s/distracted-yonath-6l27d?file=/build/index.js:0-26767
@AdityaSrivast Can you help me with codesandbox? I imported my branch into it. But build/index.js shows many problems although it works fine in vscode. This is the link for codesandbox - https://codesandbox.io/s/distracted-yonath-6l27d?file=/build/index.js:0-26767
@AdityaSrivast Can you help with this so that the PR can be merged as we have only 2 days left?
@yellowwoods12 @AdityaSrivast Can you please help me with codesandbox so that I can complete this PR successfully?
@Rukmini-Meda use test-server github url while importing, and add the code for module like Pincode.js and paste your code from App.js to it (do not install react-pincode as dependency, otherwise your changes will not appear). Also add your css file. That should do the trick.
Resolve conflicts and make the changes which I asked previously and we'll merge it through. :+1: