ncp icon indicating copy to clipboard operation
ncp copied to clipboard

Optionally using graceful-fs if it's available

Open adam-lynch opened this issue 10 years ago • 3 comments

Related: #16 and https://github.com/jprichardson/node-fs-extra/pull/95

adam-lynch avatar Dec 08 '14 15:12 adam-lynch

I think we should just add graceful-fs as an explicit dependency and potentially use it instead of controlling concurrency (iirc, concurrency control was introduced to prevent running out of fd's) (cc @AvianFlu)

mmalecki avatar Dec 09 '14 12:12 mmalecki

It'd be cool to get this merged in the meantime as this PR doesn't require the addition of any dependency. Any projects that depend up on ncp could then also use graceful-fs and leverage the benefits of graceful-fs in ncp without any practical cost to ncp or its codebase.

jprichardson avatar Dec 12 '14 22:12 jprichardson

I think this is a nice change... :-) I don't like hard dependencies for stuff like this (considering many don't npm dedupe their repos, and often version settings leave multiple versions, even if they're actually compatible for the use case.

tracker1 avatar Dec 18 '14 17:12 tracker1