AvianFlu
A way of creating directory if it doesn't exist?
:+1: really looking forward for this feature. This will allow not requiring to wrap ncp() with fs.mkdir() (or something alike).
There's so many unmerged pull requests on this repo. maybe it's time for somebody to fork this repo, merge them all, and publish.
Well. I can help advise, but I don't have a whole workday to devote to this. @pgangwani are you a javascript developer?
Yes , i am . I couldn't find any PR in the forked branch . May be need some one to review most of important and merge.
On 15-Feb-2017 3:30 AM, "Jonah" [email protected] wrote:
Well. I can help advise, but I don't have a whole workday to devote to this. @pgangwani https://github.com/pgangwani are you a javascript developer?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/AvianFlu/ncp/issues/54#issuecomment-279849887, or mute the thread https://github.com/notifications/unsubscribe-auth/ANpzLBvRIF02aBlNmzB4UdlUQAx2F5NDks5rciQJgaJpZM4Cc_8e .
Ah yes. So your forked repo won't have these fine people's pull requests, since they didn't request YOU for the pull request :)
take a look at this graph: https://github.com/AvianFlu/ncp/network That's all the people who have forked this repo and added their own changes. I suggest u look through them all (or the list of PRs on this repo), add their repos as remotes, and merge all their changes into one updated version of this repo :)
If you do that successfully, we may be able to petition npm for the rights to this module, since the author seems to have dropped off the map.
Unfortunately, I didn't get time, I am adding you as collabrator , Please help there
On Wed, Feb 15, 2017 at 9:59 PM, Jonah [email protected] wrote:
@pgangwani https://github.com/pgangwani Did you find a solution? Need any help?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/AvianFlu/ncp/issues/54#issuecomment-280060540, or mute the thread https://github.com/notifications/unsubscribe-auth/ANpzLNwYgm93s5THpzGIJmudMqXc9y4tks5rcyfcgaJpZM4Cc_8e .
https://github.com/pgangwani/ncp
On Wed, Feb 15, 2017 at 11:48 PM, Jonah [email protected] wrote:
Uh no. can you send me a link to what you're talking about?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/AvianFlu/ncp/issues/54#issuecomment-280093026, or mute the thread https://github.com/notifications/unsubscribe-auth/ANpzLMtossmmK3mSiluVAEApIyBxfZQGks5rc0FngaJpZM4Cc_8e .
Cool. I would suggest running tests and making sure the code works after merging all those.
OK , I am merging so many PRs for first time, can you run whatever I have done till now.
On Thu, Feb 16, 2017 at 12:18 AM, Jonah [email protected] wrote:
Cool. I would suggest running tests and making sure the code works after merging all those.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/AvianFlu/ncp/issues/54#issuecomment-280101571, or mute the thread https://github.com/notifications/unsubscribe-auth/ANpzLB_Xpr-ZhkgxmtwZNDJ9nTRCN4VJks5rc0iGgaJpZM4Cc_8e .
Do I need to configure test somewhere for new PRs
On Thu, Feb 16, 2017 at 12:19 AM, pawan gangwani [email protected] wrote:
OK , I am merging so many PRs for first time, can you run whatever I have done till now.
On Thu, Feb 16, 2017 at 12:18 AM, Jonah [email protected] wrote:
Cool. I would suggest running tests and making sure the code works after merging all those.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/AvianFlu/ncp/issues/54#issuecomment-280101571, or mute the thread https://github.com/notifications/unsubscribe-auth/ANpzLB_Xpr-ZhkgxmtwZNDJ9nTRCN4VJks5rc0iGgaJpZM4Cc_8e .
I don't quite understand your question. Basically, you should read all the code for this module, evaluate various pull requests, merge the ones you think belong in the module. make sure it works, make sure there is adequate test coverage, then publish a new module that you are happy with.
If the module is an improvement on the original, you can suggest a pull request to this repo, or publish on npm under a different name.
If you think the community will find your improved version more useful, we can petition npm to take the module name from this outdated repo.
Yeah, thanks man, I could manage to merge 16 , 26 more to review.
On Thu, Feb 16, 2017 at 12:47 AM, Jonah [email protected] wrote:
I don't quite understand your question. Basically, you should read all the code for this module, evaluate various pull requests, merge the ones you think belong in the module. make sure it works, make sure there is adequate test coverage, then publish a new module that you are happy with.
If the module is an improvement on the original, you can suggest a pull request to this repo, or publish on npm under a different name.
If you think the community will find your improved version more useful, we can petition npm to take the module name from this outdated repo.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/AvianFlu/ncp/issues/54#issuecomment-280109797, or mute the thread https://github.com/notifications/unsubscribe-auth/ANpzLNAQUgiUJhiOZCY_sxgf4sCWPBj2ks5rc09igaJpZM4Cc_8e .