Marcus Noble

Results 185 comments of Marcus Noble

@sriramandev These are the lint failures that are related to this PRs changes: ``` WARNING Listing 10 violation(s) that are fatal var-naming[no-role-prefix]: Variables names from within roles should use gpu_...

Hi @dntosas could you please provide more information as to what it is exactly you want and what you have tried so far? What is AL2023? Is it Amazon Linux?...

Two of the failures look like they might be related to this PR: ``` yaml[trailing-spaces]: Trailing spaces ansible/roles/node/defaults/main.yml:99 yaml[trailing-spaces]: Trailing spaces ansible/roles/node/meta/main.yml:36 ``` (See https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_image-builder/1459/pull-lint/1786044902249861120#1:build-log.txt%3A1158)

It looks like something might not be right with the 24.04 builds. Based on the log from that last run it doesn't get past the ssh stage: https://storage.googleapis.com/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_image-builder/1459/pull-ova-all/1786249412729638912/artifacts/ubuntu-2404.log

I'm not sure about VSphere myself 😞 Maybe @kkeshavamurthy can offer some suggestion?

@jepio Out of curiosity, why do you have that local change? Could that possibly be the solution here?

Is that when running in the container though? If so, that'd be a problem for everyone wouldn't it? I think it make sense to add it regardless as we want...

Cannot update as conflicts with other dependencies that are now archived.

Is this PR ready to go now? Anything more outstanding?

Big +1 to that! Or at the very least a summary similar to Sonobuoy that lets you know how many have passed/failed/not yet run.