avalonia-docs icon indicating copy to clipboard operation
avalonia-docs copied to clipboard

Update add-data-persistence.md

Open Simusharp opened this issue 1 year ago • 3 comments

In a load method, if the directory does exist, we should return an empty collection not creating the directory and iterate over the files.

Simusharp avatar Sep 30 '24 04:09 Simusharp

The diff adds a bug. I don't know if it crashes the app, or if the breakage is limited to the load method. I haven't run the app, I just looked three lines down in the diff.

djeikyb avatar Oct 23 '24 19:10 djeikyb

The diff adds a bug. I don't know if it crashes the app, or if the breakage is limited to the load method. I haven't run the app, I just looked three lines down in the diff.

Can you elaborate about the bug?

Simusharp avatar Nov 03 '24 03:11 Simusharp

On review, I'm wrong about this introducing a bug. I do wonder about keeping the code in these docs and the tutorial repo in sync.

djeikyb avatar Nov 08 '24 23:11 djeikyb