avalonia-docs icon indicating copy to clipboard operation
avalonia-docs copied to clipboard

Update displaying-images.md

Open Simusharp opened this issue 1 year ago • 2 comments

There is a typo in the logic; it should IsVisible when IsNotNull

Simusharp avatar Sep 29 '24 02:09 Simusharp

@Simusharp Are you sure about this change?

  1. This whole section is designed to teach IsNull as an intro to converters. This is not a typo-level mistake. It'd be surprising if it was this wrong for this long.
  2. If the IsNull in the code block is wrong, then it's probably also wrong in the paragraph that references the code block. You changed the code block but didn't address any of the corresponding tutorial text.
  3. Did you test this code change? I don't think there's any automation for testing tutorial code blocks, but it'd be good to know if you've validated the PR by running the code

djeikyb avatar Oct 23 '24 18:10 djeikyb

@djeikyb

@Simusharp Are you sure about this change?

1. This whole section is designed to teach IsNull as an intro to converters. This is not a typo-level mistake. It'd be surprising if it was _this_ wrong for _this_ long.

2. If the IsNull in the code block is wrong, then it's probably also wrong in the paragraph that references the code block. You changed the code block but didn't address any of the corresponding tutorial text.

3. Did you test this code change? I don't think there's any automation for testing tutorial code blocks, but it'd be good to know if you've validated the PR by running the code

I just tried the example today. Yes, it's wrong, it has to be IsNotNull as the OP suggested.

I've add a new PR, which has fixed as suggested: https://github.com/AvaloniaUI/avalonia-docs/commit/4828b55990de87c21ca315647dc896ac707f75c1

ruxo avatar Dec 11 '24 03:12 ruxo