AvaloniaEdit icon indicating copy to clipboard operation
AvaloniaEdit copied to clipboard

Syntax highlighting fails under mac

Open chenjing1294 opened this issue 2 years ago • 5 comments

截屏2022-10-10 上午11 40 19

chenjing1294 avatar Oct 10 '22 03:10 chenjing1294

It's working fine in my mac... image

What macOS version/architecture are you trying?

danipen avatar Oct 10 '22 07:10 danipen

It's working fine in my mac... image

What macOS version/architecture are you trying?

macOS Monterey 12.6 / M1 Pro, After I recompiled oniguruma, put it in the running directory and it returned to normal. Does it not support M1?

chenjing1294 avatar Oct 10 '22 08:10 chenjing1294

After I recompiled oniguruma, put it in the running directory and it returned to normal. Does it not support M1?

Not sure, maybe not.

@Gillibald is the syntax highlight working for you? Are you using M1? My macOS is an intel-based one, so I cannot check that.

@chenjing1294 just to double check ... the Oniguruma bindings are provided by TextMateSharp. So ... question: is the TextMateSharp demo working for you? If the answer is no ... we would need to re-build the oniguruma bindings with M1 support.

danipen avatar Oct 10 '22 09:10 danipen

@chenjing1294 just to double check ... the Oniguruma bindings are provided by TextMateSharp. So ... question: is the TextMateSharp demo working for you? If the answer is no ... we would need to re-build the oniguruma bindings with M1 support.

TextMateSharp demo didn't work for me until I recompiled oniguruma on M1.

chenjing1294 avatar Oct 10 '22 09:10 chenjing1294

Oh ok, so it seems we need a new build for the oniguruma bindings.

@chenjing1294 some help would be appreciated so if you generate a universal build of the onigwrap dylib I can generate a new TextMateSharp nuget and fix the issue in AvaloniaEdit.

danipen avatar Oct 10 '22 09:10 danipen

I generated a new version of the native onigwrap library with both x64 abd arm64 support, so now macOS M1 should be supported.

I cannot test M1, so please, @chenjing1294 could you try to manually replace the native binary with this one, and check if it's working fine for M1 now? Thanks in advance!

danipen avatar Oct 15 '22 17:10 danipen

@chenjing1294 did you have a chance to test it?

danipen avatar Oct 18 '22 07:10 danipen

@chenjing1294 did you have a chance to test it?

Great, problem solved, thank you.😊

chenjing1294 avatar Oct 18 '22 09:10 chenjing1294