Avalonia icon indicating copy to clipboard operation
Avalonia copied to clipboard

Fix NotificationCard to determine the type of notification from an inherited INotification object

Open Onebeld opened this issue 2 years ago • 3 comments

What does the pull request do?

Fixed a very small flaw where NotificationCard only defined the notification type from the Notification class, but not from the INotification interface, resulting in the notification type always remaining the default if the object is inherited from the interface.

What is the updated/expected behavior with this PR?

NotificationCard now takes all classes inherited from INotification to define the type of notification.

Onebeld avatar Jul 08 '23 08:07 Onebeld

@Onebeld please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@dotnet-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@dotnet-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@dotnet-policy-service agree company="Microsoft"

Contributor License Agreement

@dotnet-policy-service agree

Onebeld avatar Jul 08 '23 08:07 Onebeld

You can test this PR using the following package version. 11.0.999-cibuild0037548-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

avaloniaui-team avatar Jul 08 '23 08:07 avaloniaui-team