Avalonia
Avalonia copied to clipboard
AvaloniaUI
fix DropDownButton glyph foreground color
What does the pull request do?
Makes the dropdown glyph part of a DropDownButton match the foreground when mouse over and pressing
What is the current behavior?
Currently the glyph foreground only changes when disabled
What is the updated/expected behavior with this PR?
Hovering the drop down button should make the glyph match the Foreground, same when pressed
How was the solution implemented (if it's not obvious)?
Checklist
- [ ] Added unit tests (if possible)?
- [ ] Added XML documentation to any related classes?
- [ ] Consider submitting a PR to https://github.com/AvaloniaUI/Documentation with user documentation
Breaking changes
Fixed issues
- This is intentional: None of the other drop-down type controls in Avalonia change glyph brush on pointer over in Fluent theme.
- We SHOULD NOT be changing this style without also changing ComboBox, SplitButton, ToggleSplitButton, etc.
- We are following Fluent v1 from Windows 10 (not Fluent v2 in Windows 11). I believe Fluent v1 didn't do this but could be wrong and didn't check.
So I wouldn't merge this PR as-is.
You can test this PR using the following package version. 11.0.999-cibuild0037399-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]
I can take a look at doing the other controls with glyphs, i just didn't think to check if they also had the same problem.
If it's intentional then I'm happy to just close this and I can change it in my app specifically, it just became very apparent that it doesn't function well when I was messing with the theme pallet.
I'm not opposed to the change if it is done uniformly to all related controls. We probably should see what others think though.
Eventually, Fluent really should move to v2 (or actually v3 with Windows 12). We also ideally should decide whether to follow upstream or just create an Avalonia theme with all deviations allowed instead. Larger topic to think about.
I realize upstream might have stopped using these resources due to the introduction of lottie animations and the AnimatedIcon used for the glyph now.
I'll plan on going through the other controls later sometime. I do think we need to be consistent with design language in the other controls that have a drop-down glyph.