Avalonia icon indicating copy to clipboard operation
Avalonia copied to clipboard

Published 20 hours ago • verified publisher icon AvaloniaUI

[WIP] Init work with MenuItem.ToggleType

Open maxkatz6 opened this issue 1 year ago • 3 comments

What does the pull request do?

  • [x] Adds MenuItem.ToggleType APIs
  • [ ] Polish radio button functionality (i.e. it should work with hierarchy property).
  • [x] Add fluent styles for radio/simple menu items
  • [x] Add simple styles for radio/simple menu items
  • [x] Integrate into NativeMenuItem
  • [x] Ensure that it's usable with binding menus
  • [ ] Add tests
  • [ ] (bonus) Add icon and separator support for the top-level Menu
  • [ ] (optional) Remove support for Header="-", but instead generate Separator container depending on the data context

https://github.com/AvaloniaUI/Avalonia/assets/3163374/3512b24a-ed26-4d7b-be39-af3db262d167

Checklist

  • [ ] Added unit tests (if possible)?
  • [ ] Added XML documentation to any related classes?
  • [ ] Consider submitting a PR to https://github.com/AvaloniaUI/Documentation with user documentation

Fixed issues

tbd Fixes #7663 Fixes #224 Fixes #1902 Fixes #5397 Maybe #10794

maxkatz6 avatar May 19 '23 03:05 maxkatz6

You can test this PR using the following package version. 11.0.999-cibuild0035049-beta. (feed url: https://pkgs.dev.azure.com/AvaloniaUI/AvaloniaUI/_packaging/avalonia-all/nuget/v3/index.json) [PRBUILDID]

avaloniaui-team avatar May 19 '23 04:05 avaloniaui-team

Remove support for Header="-", but instead generate Separator container depending on the data context

Yep, this should now be possible with the recent changes to how container generation works.

grokys avatar May 19 '23 07:05 grokys

You can test this PR using the following package version. 11.0.999-cibuild0035163-beta. (feed url: https://pkgs.dev.azure.com/AvaloniaUI/AvaloniaUI/_packaging/avalonia-all/nuget/v3/index.json) [PRBUILDID]

avaloniaui-team avatar May 21 '23 02:05 avaloniaui-team

Any update on this? Since the release of Avalonia 11, the old workaround of adding a checkbox as a MenuItem Icon doesn't work properly https://github.com/amwx/FluentAvalonia/issues/367

IsaacMarovitz avatar Jul 14 '23 18:07 IsaacMarovitz

Is this PR still being worked on?

jgcodes2020 avatar Aug 09 '23 14:08 jgcodes2020

Closing this PR temporarily due to inactivity. Please ping me if this needs to be reopened.

jmacato avatar Nov 17 '23 07:11 jmacato

@jmacato Why wasn't it merged? Would be nice to have this feature

toomasz avatar Nov 23 '23 14:11 toomasz

Closing this PR temporarily due to inactivity. Please ping me if this needs to be reopened.

that is why. Lack of time.

timunie avatar Nov 23 '23 14:11 timunie

You can test this PR using the following package version. 11.1.999-cibuild0043062-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

avaloniaui-bot avatar Dec 19 '23 11:12 avaloniaui-bot

You can test this PR using the following package version. 11.1.999-cibuild0044129-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

avaloniaui-bot avatar Jan 29 '24 15:01 avaloniaui-bot

You can test this PR using the following package version. 11.1.999-cibuild0044411-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

avaloniaui-bot avatar Feb 04 '24 03:02 avaloniaui-bot

You can test this PR using the following package version. 11.1.999-cibuild0044537-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

avaloniaui-bot avatar Feb 07 '24 08:02 avaloniaui-bot